Conversation
…r recovery When current_wan_ifname transitions back to erouter0, wanfailover_handleTunnel(true) already fully creates gretap0 and all VLAN sub-interfaces/bridges via jansson_rollback_tunnel_info(). However gbFirstPrimarySignal and gTunnelIsUp were left in the state set during the brRWAN transition (true/false), causing the keep-alive ping thread to fire sysevent kHotspotfd_tunnelEP on the next successful ping. This triggered the GRE EP script to destroy and recreate gretap0, which removes all VLAN sub-interfaces from their bridges, leaving brlan3-5, bropen6g and brsecure6g without gretap interfaces. Fix: add else branch in hotspot_check_wan_failover_status to set gTunnelIsUp=true and gbFirstPrimarySignal=false immediately after the tunnel is restored by wanfailover_handleTunnel(true), so the ping thread does not trigger a redundant tunnel recreate.
… failover recovery" This reverts commit 2d84038.
There was a problem hiding this comment.
Pull request overview
Ensures hotspot SSID enable-state handling runs during WAN failover/restore so GRE tap tunnels can be recreated correctly after WAN restoration (addressing RDKB-64090).
Changes:
- Removed
#if !defined(RDK_ONEWIFI)guards so SSID validation/update logic runs for RDK_ONEWIFI builds as well during tunnel status transitions. - Always calls
get_validate_ssid()before marking tunnels down on remote-WAN, andset_validatessid()before marking tunnels up on primary-WAN.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apattu200
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-64090: Upon WAN restore gretaps not created
Reason for change: SSIDs are not updated before WAN failover.
Test Procedure: Remove the RF feed to trigger the WFO and connect back.
Risks: High
Priority: P0
Signed-off-by: BalajiChowdary_Unnam@comcast.com