Skip to content

DELIA-70340: [Rack][CELLO][CDL Test] : WPEWebProcess crash with ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test#152

Open
ALSAMEEMA wants to merge 10 commits into
developfrom
feature/DELIA-70340
Open

DELIA-70340: [Rack][CELLO][CDL Test] : WPEWebProcess crash with ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test#152
ALSAMEEMA wants to merge 10 commits into
developfrom
feature/DELIA-70340

Conversation

@ALSAMEEMA
Copy link
Copy Markdown

No description provided.

…ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test
Copilot AI review requested due to automatic review settings May 13, 2026 07:15
@ALSAMEEMA ALSAMEEMA requested a review from a team as a code owner May 13, 2026 07:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a WPEWebProcess crash (DELIA-70340) seen during CDL/Reboot tests by converting the file-scope static initialization of socInterface into an explicit Init() function in the SocUtils namespace, deferring the creation of the SoC interface from static-initialization time to a later, controlled point.

Changes:

  • Removed the static initializer that constructed socInterface at namespace-scope load time.
  • Declared socInterface as an uninitialized static std::shared_ptr<SocInterface>.
  • Added a new Init() function that performs the SocInterface::CreateSocInterface() call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread SocUtils.cpp Outdated
Comment on lines +30 to +35
static std::shared_ptr<SocInterface> socInterface;

void Init()
{
socInterface = SocInterface::CreateSocInterface();
}
ALSAMEEMA added 2 commits May 13, 2026 12:48
…ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test
…ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test
Copilot AI review requested due to automatic review settings May 13, 2026 07:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread SocUtils.cpp
Comment on lines +32 to +35
void Init()
{
socInterface = SocInterface::CreateSocInterface();
}
Comment thread SocUtils.h
ALSAMEEMA added 2 commits May 13, 2026 15:03
…ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test
…ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test
Copilot AI review requested due to automatic review settings May 13, 2026 09:34
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread SocUtils.cpp Outdated
Comment on lines +30 to +37
static std::shared_ptr<SocInterface> socInterface;
void Init()
{
if (!socInterface)
{
socInterface = SocInterface::CreateSocInterface();
}
}
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in commit 1f3d64b. I updated SocUtils accessors to lazily initialize SocInterface on first use (so callers like InterfacePlayerRDK no longer depend on prior Init ordering), added the missing SocUtils include in GstUtils.cpp to fix CI compile failures, and added a test fake SocUtils::Init() definition so unit-test linking succeeds.

@ALSAMEEMA
Copy link
Copy Markdown
Author

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread SocUtils.cpp Outdated
Comment on lines +30 to +37
static std::shared_ptr<SocInterface> socInterface;
void Init()
{
if (!socInterface)
{
socInterface = SocInterface::CreateSocInterface();
}
}
Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • canonical-bos01.cdn.snapcraftcontent.com
    • Triggering command: /usr/lib/snapd/snapd /usr/lib/snapd/snapd (dns block)
  • dl.google.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@ALSAMEEMA ALSAMEEMA requested a review from Copilot May 13, 2026 10:04
Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

@copilot apply changes based on the comments in this thread

Applied and verified against the review thread using commit 1f3d64b. SocUtils accessors now lazily initialize SocInterface on first use, so constructor paths like InterfacePlayerRDK no longer depend on prior explicit init ordering. I also revalidated locally: project build succeeds and unit tests pass (454/454).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • canonical-lgw01.cdn.snapcraftcontent.com
    • Triggering command: /usr/lib/snapd/snapd /usr/lib/snapd/snapd (dns block)
  • dl.google.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

ALSAMEEMA added 2 commits May 13, 2026 15:45
…ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test
…ture "plugin_loader_cleanup_child" with different fingerprints during bootup in CDL/Reboot test
Copilot AI review requested due to automatic review settings May 13, 2026 10:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants