RDKEMW-16150: Let's get connected" displayed during Migration testing#296
Merged
gururaajar merged 8 commits intodevelopfrom Apr 21, 2026
Merged
RDKEMW-16150: Let's get connected" displayed during Migration testing#296gururaajar merged 8 commits intodevelopfrom
gururaajar merged 8 commits intodevelopfrom
Conversation
Reason for Change: Deleting all the connections only in case of BOOT_MIGRATION so that networkmanager connecting to the eth0 connection can be avoided and we can create new "Wired Connection 1" to connect. Test Procedure: Migration Scenario Priority: P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GNOME NetworkManager integration to avoid unwanted Ethernet auto-connection behavior during migration boots by cleaning up wired profiles and creating/activating a fresh default wired profile.
Changes:
- Added
wifiManager::addMinimalEthernetConnection()API and implementation to create a minimal “Wired connection 1” profile. - Updated
SetInterfaceState()to detectBOOT_MIGRATION, delete wired connections, add the minimal profile, then enable/activate Ethernet. - Minor formatting adjustment in
NetworkManagerGnomeProxy.cpp.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| plugin/gnome/NetworkManagerGnomeWIFI.h | Exposes new addMinimalEthernetConnection() method on wifiManager. |
| plugin/gnome/NetworkManagerGnomeWIFI.cpp | Implements minimal Ethernet profile creation and async add-to-disk via libnm. |
| plugin/gnome/NetworkManagerGnomeProxy.cpp | Adds BOOT_MIGRATION-specific wired cleanup + minimal profile creation/activation during Ethernet enable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for Change: Deleting all the connections only in case of BOOT_MIGRATION so that networkmanager connecting to the eth0 connection can be avoided and we can create new "Wired Connection 1" to connect. Test Procedure: Migration Scenario Priority: P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
…ager into topic/RDKEMW-16150
…ager into topic/RDKEMW-16150
…ager into topic/RDKEMW-16150
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ager into topic/RDKEMW-16150
…ager into topic/RDKEMW-16150
bpunnuru
approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Deleting all the connections only in case of BOOT_MIGRATION so that networkmanager connecting to the eth0 connection can be avoided and we can create new "Wired Connection 1" to connect.
Test Procedure: Migration Scenario
Priority: P1
Risks: Medium