GH90 - interactive ssh shell#91
Merged
Merged
Conversation
|
zghp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
TB-1993
requested changes
Sep 6, 2024
Contributor
TB-1993
left a comment
TB-1993
left a comment
There was a problem hiding this comment.
I think ultimately we need a complete overhaul of our console classes to get them all behaving the same. They all have minor differences at the moment and it will ruin our tests.
| while self.buffer.__len__() > 0: | ||
| data = data + self.buffer.pop(0) | ||
| return data | ||
| return self.full_output |
Contributor
There was a problem hiding this comment.
We could continue to use buffer here and still do this as a list. Then we wouldn't need the new attribute and wouldn't change the behaviour of the method too much.
…g a session for each method call
zghp
force-pushed
the
feature/gh90_interactive_ssh_shell
branch
from
657eb5e to
762009a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.