gh #44 Initial L3 C-Test Code generation. - #45
Merged
Conversation
Ulrond
requested changes
Jul 26, 2024
Contributor
There was a problem hiding this comment.
this needs re-doing.
We need to have a meeting to discuss the high level requirement, which this doesn't meet.
The tests are platform-agnostic, and also will not know about the CEC Adaptor.
The test will run on both the vDevice and all platforms real or with CEC Adaptors, and must be platform agnostic and device Agnostic.
There will be no changes to the test to swap to vDevice, Platforms with CEC Adaptors or not.
srinivasgtl
commented
Jul 28, 2024
srinivasgtl
left a comment
Contributor
Author
There was a problem hiding this comment.
Let's discuss more on the design.
Correcting the typo mistakes.
Updated with lib cec commands.
Typo mistakes
Updated with some basic RAFT requirements. Modified the design to use only a single Adaptor which can send, receive, and respond to the commands.
Updating RAFT info.
RAFT updates.
removed unwanted data.
Updating with review comments.
Updated with review comments
enhancement to the sequence diagram
srinivasgtl
force-pushed
the
feature/gh44_hdmicec_l3_sink_tests
branch
from
August 6, 2024 17:00
a298360 to
b4197d2
Compare
Added python file to run all tests Used monitor function to get the adaptor logs
Updated with review comments
bhanucbp
force-pushed
the
feature/gh44_hdmicec_l3_sink_tests
branch
from
December 17, 2024 14:27
20fe937 to
2ce8ce1
Compare
Updated test for source devices
Updated tests with new raft implementation
Initialized global handle with correct value
Updated raft tag
Updated specification document
Updated the test procedure document
Corrected the physical address format
Updated test procedure document
bhanucbp
force-pushed
the
feature/gh44_hdmicec_l3_sink_tests
branch
from
December 27, 2024 16:42
199bc3a to
5a2e554
Compare
Corrected merge conflicts
srinivasgtl
commented
Dec 30, 2024
Added virtual device code
srinivasgtl
commented
Dec 30, 2024
srinivasgtl
commented
Dec 30, 2024
srinivasgtl
commented
Dec 30, 2024
Addressed review comments
hari22yuva
reviewed
Dec 30, 2024
Ulrond
requested changes
Dec 30, 2024
Ulrond
left a comment
Contributor
There was a problem hiding this comment.
- won't scale.
- unclear requirements for driver testing
Addressed review comments
- Addressed review comments - Moved cec responses to different yml file under assets folder - Updated the exectute command to take the cec response file
Ulrond
approved these changes
Dec 31, 2024
Ulrond
left a comment
Contributor
There was a problem hiding this comment.
- Later We should document the requirement on what the hdmi_cec_driver does
- We should also document each of the commands in more detail from the CEC, so we know what they are when we need to amend and maintain them
hari22yuva
approved these changes
Jan 2, 2025
hari22yuva
left a comment
Contributor
There was a problem hiding this comment.
approved as per requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #44 - Initial L3 low spec document for hdmi cec sink module.