Skip to content

gh #44 Initial L3 C-Test Code generation. - #45

Merged
hari22yuva merged 41 commits into
developfrom
feature/gh44_hdmicec_l3_sink_tests
Jan 2, 2025
Merged

gh #44 Initial L3 C-Test Code generation.#45
hari22yuva merged 41 commits into
developfrom
feature/gh44_hdmicec_l3_sink_tests

Conversation

@srinivasgtl

Copy link
Copy Markdown
Contributor

Issue #44 - Initial L3 low spec document for hdmi cec sink module.

@srinivasgtl srinivasgtl self-assigned this Jul 19, 2024
@srinivasgtl srinivasgtl linked an issue Jul 19, 2024 that may be closed by this pull request
@srinivasgtl srinivasgtl added the L3 Work Element L3 Development work. label Jul 19, 2024

@Ulrond Ulrond left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs re-doing.

We need to have a meeting to discuss the high level requirement, which this doesn't meet.

The tests are platform-agnostic, and also will not know about the CEC Adaptor.

The test will run on both the vDevice and all platforms real or with CEC Adaptors, and must be platform agnostic and device Agnostic.

There will be no changes to the test to swap to vDevice, Platforms with CEC Adaptors or not.

Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread profiles/sink/sink_hdmiCEC_test.yml Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated

@srinivasgtl srinivasgtl left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss more on the design.

Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
Comment thread docs/pages/hdmi-cec-sink-L3-Low-Level_TestSpec.md Outdated
@Ulrond Ulrond added the documentation Improvements or additions to documentation label Jul 29, 2024
@srinivasgtl
srinivasgtl force-pushed the feature/gh44_hdmicec_l3_sink_tests branch from a298360 to b4197d2 Compare August 6, 2024 17:00
@srinivasgtl srinivasgtl changed the title gh #44 Initial L3 Low level desig document for the hdmi cec sink device gh #44 Initial L3 C-Test Code generation. Sep 4, 2024
@CLAassistant

CLAassistant commented Nov 24, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Added python file to run all tests
Used monitor function to get the adaptor logs
Updated with review comments
@bhanucbp
bhanucbp force-pushed the feature/gh44_hdmicec_l3_sink_tests branch from 20fe937 to 2ce8ce1 Compare December 17, 2024 14:27
Updated test for source devices
Updated tests with new raft implementation
Initialized global handle with correct value
Updated raft tag
Updated specification document
Updated the test procedure document
Corrected the physical address format
Updated test procedure document
@bhanucbp
bhanucbp force-pushed the feature/gh44_hdmicec_l3_sink_tests branch from 199bc3a to 5a2e554 Compare December 27, 2024 16:42
Comment thread host/tests/hdmiCEC_L3_Tests/hdmiCEC_test01_TransmitCECCommands.py
Added virtual device code
Comment thread host/tests/classes/hdmiCEC.py Outdated
Comment thread host/tests/configs/example_rack_config.yml Outdated
Comment thread host/tests/hdmiCEC_L3_Tests/hdmiCEC_test02_ReceiveCECCommands.py
Addressed review comments

@Anbukannadhasan Anbukannadhasan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hari22yuva hari22yuva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check

Comment thread host/tests/classes/hdmiCEC.py Outdated
Comment thread host/tests/classes/hdmiCEC.py Outdated
Comment thread docs/pages/hdmi-cec-L3-Low-Level_TestSpec.md
Comment thread src/test_l3_hdmi_cec_driver.c Outdated
Comment thread docs/pages/hdmi-cec-L3_TestProcedure.md
Comment thread host/tests/hdmiCEC_L3_Tests/hdmiCEC_test01_TransmitCECCommands.py

@Ulrond Ulrond left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • won't scale.
  • unclear requirements for driver testing

Comment thread docs/pages/hdmi-cec-L3_TestProcedure.md
Comment thread host/activate_venv.sh
Comment thread host/tests/configs/example_rack_config.yml
Comment thread host/tests/configs/deviceConfig.yml Outdated
Comment thread host/tests/hdmiCEC_L3_Tests/hdmiCECTestCommands.yml Outdated
Comment thread profiles/source/source_hdmiCEC.yml Outdated
Comment thread src/test_l3_hdmi_cec_driver.c
Comment thread src/test_l3_hdmi_cec_driver.c
Comment thread src/test_l3_hdmi_cec_driver.c
Comment thread src/test_vd_hdmi_cec_driver.c
Addressed review comments
- Addressed review comments
- Moved cec responses to different yml file under assets folder
- Updated the exectute command to take the cec response file

@Ulrond Ulrond left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Later We should document the requirement on what the hdmi_cec_driver does
  • We should also document each of the commands in more detail from the CEC, so we know what they are when we need to amend and maintain them

@hari22yuva hari22yuva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as per requirement

@hari22yuva
hari22yuva merged commit 2cd6c51 into develop Jan 2, 2025
@hari22yuva
hari22yuva deleted the feature/gh44_hdmicec_l3_sink_tests branch January 2, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation L3 Work Element L3 Development work.

Projects

Status: Resolved

Development

Successfully merging this pull request may close these issues.

L3 C-Test code - HDMI CEC - Sink device

7 participants