RDKEMW-13250: Memory Metrics analysis for VIPA#123
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “MiniJSDOM” mode to the JS runtime to support memory-metrics analysis for VIPA by optionally loading a lightweight DOM/fetch/window shim.
Changes:
- Add
enableMiniJSDOMtoModuleSettingsand propagate it throughApplicationRequest/renderer creation flow. - Add a new CLI flag (
--enableMiniJSDOM) and a new JS module (minified_linkedjsdom.js) that provides a minimal DOM/window/fetch environment. - Update
JavaScriptContextinitialization to load the new module whenenableMiniJSDOMis set.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/jsruntime.cpp | Adds --enableMiniJSDOM argument parsing to toggle the new mode. |
| src/jsc/modules/minified_linkedjsdom.js | Introduces a lightweight DOM/window/fetch/timer shim used by MiniJSDOM mode. |
| src/jsc/JavaScriptContext.cpp | Loads minified_linkedjsdom.js (and url.js) when MiniJSDOM is enabled. |
| src/NativeJSRenderer.cpp | Passes enableMiniJSDOM through ApplicationRequest into ModuleSettings. |
| src/ModuleSettings.cpp | Initializes/copies enableMiniJSDOM and adds parsing from string options. |
| include/NativeJSRenderer.h | Extends ApplicationRequest to carry enableMiniJSDOM. |
| include/ModuleSettings.h | Adds the enableMiniJSDOM flag to the settings struct. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Added minified jsdom for widget Test Procedure: build should be successful Risk: low Priority: P2
6c12737 to
de253bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added minified jsdom for widget
Test Procedure: build should be successful
Risk: low
Priority: P2