Skip to content

RDKEMW-13250: Memory Metrics analysis for VIPA#123

Merged
vjain008 merged 1 commit into
developfrom
topic/RDKEMW-13250
Feb 17, 2026
Merged

RDKEMW-13250: Memory Metrics analysis for VIPA#123
vjain008 merged 1 commit into
developfrom
topic/RDKEMW-13250

Conversation

@gurpreet319
Copy link
Copy Markdown
Contributor

Reason for change: Added minified jsdom for widget
Test Procedure: build should be successful
Risk: low
Priority: P2

@gurpreet319 gurpreet319 requested a review from a team as a code owner February 16, 2026 11:33
Copilot AI review requested due to automatic review settings February 16, 2026 11:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “MiniJSDOM” mode to the JS runtime to support memory-metrics analysis for VIPA by optionally loading a lightweight DOM/fetch/window shim.

Changes:

  • Add enableMiniJSDOM to ModuleSettings and propagate it through ApplicationRequest/renderer creation flow.
  • Add a new CLI flag (--enableMiniJSDOM) and a new JS module (minified_linkedjsdom.js) that provides a minimal DOM/window/fetch environment.
  • Update JavaScriptContext initialization to load the new module when enableMiniJSDOM is set.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/jsruntime.cpp Adds --enableMiniJSDOM argument parsing to toggle the new mode.
src/jsc/modules/minified_linkedjsdom.js Introduces a lightweight DOM/window/fetch/timer shim used by MiniJSDOM mode.
src/jsc/JavaScriptContext.cpp Loads minified_linkedjsdom.js (and url.js) when MiniJSDOM is enabled.
src/NativeJSRenderer.cpp Passes enableMiniJSDOM through ApplicationRequest into ModuleSettings.
src/ModuleSettings.cpp Initializes/copies enableMiniJSDOM and adds parsing from string options.
include/NativeJSRenderer.h Extends ApplicationRequest to carry enableMiniJSDOM.
include/ModuleSettings.h Adds the enableMiniJSDOM flag to the settings struct.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/jsc/modules/minified_linkedjsdom.js Outdated
Comment thread src/ModuleSettings.cpp Outdated
Reason for change: Added minified jsdom for widget
Test Procedure: build should be successful
Risk: low
Priority: P2
@vjain008 vjain008 requested review from vjain008 and removed request for vjain008 February 17, 2026 05:36
@vjain008 vjain008 merged commit ffbd2d9 into develop Feb 17, 2026
8 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants