RDKEMW-2170 : Merging latest change for phase1 video tag support #5
Merged
Conversation
|
|
| injectFun(mContext, "require", requireCallback); | ||
| if(mModuleSettings.enablePlayer) | ||
| { | ||
| runFile("/home/root/modules/video.js", nullptr); |
Contributor
There was a problem hiding this comment.
Kindly use path without /home/root
Contributor
Author
There was a problem hiding this comment.
updated the changes
Contributor
There was a problem hiding this comment.
@trupthi1403
in video.js file add the below header on the top:
/**
- If not stated otherwise in this file or this component's LICENSE
- file the following copyright and licenses apply:
- Copyright 2024 RDK Management
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
**/
Contributor
Author
There was a problem hiding this comment.
@vjain008 Updated the file by adding header
trupthi1403
force-pushed
the
topic/RDKEMW-2170
branch
from
e66f6bb to
852b00d
Compare
Reason for change: Added the video.js file for video tag support Test Procedure: build should be successful and able to run main.js(application file) and verify properties: src, muted, autoplay, loop Risks: low Priority: P2
trupthi1403
force-pushed
the
topic/RDKEMW-2170
branch
from
852b00d to
e14d1d0
Compare
mfiess
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added the video.js file for video tag support
Test Procedure: build should be successful and able to run
main.js(application file) and verify properties: src, muted, autoplay, loop
Risks: low
Priority: P2