RDKEMW-8844: Analyse and Improve L1 coverage#79
Merged
Conversation
Contributor
trupthi1403
commented
Oct 31, 2025
trupthi1403
commented
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors code organization by moving inline class and struct definitions from .cpp files to header files, improves thread safety in console mode operations, and adds conditional key mappings for unit tests.
- Moved
TimeoutQueue,TimeoutInfo,TimeoutInfoComparator, andrtHttpRequestExclass/struct definitions from implementation to header files for better code organization - Enhanced thread safety in console mode by using managed threads and shutdown flags to prevent race conditions and ensure proper cleanup
- Added conditional compilation support for additional Wayland key mappings when building for unit tests
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/jsc/JavaScriptUtils.cpp | Moved inline class/struct definitions to header; methods now reference classes from header |
| include/jsc/JavaScriptUtils.h | Added declarations for TimeoutQueue, TimeoutInfo, TimeoutInfoComparator, and rtHttpRequestEx |
| src/NativeJSRenderer.cpp | Replaced detached thread with managed thread; added shutdown flag and proper thread cleanup |
| include/NativeJSRenderer.h | Added thread member, shutdown flag, and static consoleLoop variable |
| src/linux/KeyInput.cpp | Added conditional key mappings for unit test builds |
| include/jsc/JavaScriptContext.h | Made setPlaybackStartTime virtual |
| include/EssosInstance.h | Whitespace/formatting changes |
| .github/workflows/jsruntime_L1tests.yml | Updated test reference branch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trupthi1403
force-pushed
the
topic/RDKEMW-8844
branch
3 times, most recently
from
750f0a1 to
ea530cb
Compare
trupthi1403
force-pushed
the
topic/RDKEMW-8844
branch
from
ea530cb to
ce00559
Compare
Reason for change: Changes done to compile newly added test cases
Test Procedure: Able to build and run test cases in CI
Risks: low
Priority: P2
trupthi1403
force-pushed
the
topic/RDKEMW-8844
branch
from
817b398 to
605e0ad
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vjain008
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.