RDKEMW-9172: L2testcase for rdkNativeScript#91
Merged
Conversation
Reason for change: Changes to run L2 test cases Test Procedure: Able to build and run test cases in CI Risks: low Priority: P2
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds L2 test case support for the rdkNativeScript runtime. It introduces conditional compilation flags and enhanced wait time handling specifically for WebSocket-enabled test scenarios, along with code coverage instrumentation support for automated testing.
Key changes:
- Added
NATIVEJS_L2_BUILDandENABLE_COVERAGECMake options with corresponding preprocessor definitions - Enhanced wait time logic for WebSocket-enabled applications (30s vs 10s default) in developer mode
- Added explicit termination and cleanup delays for L2 test builds
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CMakeLists.txt | Adds L2 build and coverage options with compiler flags for code coverage instrumentation |
| include/NativeJSRenderer.h | Adds <thread> include for thread sleep functionality |
| src/jsruntime.cpp | Implements conditional wait times based on WebSocket enablement and adds termination delays for L2 builds |
| src/NativeJSRenderer.cpp | Adds termination delay and explicit terminate call when exiting developer console in L2 builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vjain008
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Changes to run L2 test cases
Test Procedure: Able to build and run test cases in CI
Risks: low
Priority: P2