Skip to content

Conversation

Copy link

Copilot AI commented Jan 22, 2026

Addresses feedback on #143 where std::move() on ClearDB and BootstrapClearDB made subsequent log statements uninformative.

Changes

  • Removed std::move() from ClearDB and BootstrapClearDB in set_RFCProperty() calls - short-lived locals don't benefit from move semantics
  • Enhanced log statements to include actual key values instead of generic messages
  • Aligned pattern with clearDBEnd() function for consistency
// Before
set_RFCProperty(name, std::move(ClearDB), clearValue);
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value\n", __FUNCTION__,__LINE__);

// After  
set_RFCProperty(name, ClearDB, clearValue);
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Key Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());

Also added .gitignore for autotools generated files.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits January 22, 2026 13:15
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Copilot AI changed the title [WIP] Update RDK Coverity defect resolution for device management Remove std::move() from local variables with subsequent usage in clearDB() Jan 22, 2026
Copilot AI requested a review from Vismalskumar0 January 22, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants