Session server app changed to shared ptr to avoid invalid ptrs. Some minor changes added to make code safer.#437
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
|
serverManager/common/source/SessionServerAppManager.cpp:399:13: style: Condition 'm_healthcheckService' is always false [knownConditionTrueFalse] |
|
Coverage statistics of your commit: |
Coverity Issue - Use of auto that causes a copyUsing the "auto" keyword without an "&" causes the copy of an object of type "std::string". Low Impact, CWE-none How to fixUse "const auto &" instead of "auto". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Use of auto that causes a copyUsing the "auto" keyword without an "&" causes the copy of an object of type "std::string". Low Impact, CWE-none How to fixUse "const auto &" instead of "auto". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
| { | ||
| for (const auto &tag : m_eventTags) | ||
| { | ||
| m_ipcLoop->channel()->unsubscribe(tag); |
There was a problem hiding this comment.
Coverity Issue - Unchecked return value
Calling "unsubscribe" without checking return value (as is done elsewhere 1 out of 1 times).
Medium Impact, CWE-252
CHECKED_RETURN
|
Coverage statistics of your commit: |
1 similar comment
|
Coverage statistics of your commit: |
3 participants
Summary: Session server app changed to shared ptr to avoid invalid ptrs. Some minor changes added to make code safer.
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: VPLAY-12448