Issue 70: Fix SVP CI Build Issues.#81
Merged
riwoh merged 2 commits intordkcentral:mainfrom Apr 13, 2026
Merged
Conversation
The tasecureapi headers guard SVP types (sa_svp_buffer, sa_buffer.context.svp) behind #ifdef ENABLE_SVP / #if ENABLE_SVP. The CI was only passing -DENABLE_SVP=ON when building tasecureapi itself, but not when building secapi2-adapter. This caused compile errors for unknown type 'sa_svp_buffer' and missing 'svp' member in the sa_buffer union. Pass -DENABLE_SVP=1 via CMAKE_C_FLAGS and CMAKE_CXX_FLAGS when configuring secapi2-adapter so that the installed tasecureapi headers expose SVP types.
There was a problem hiding this comment.
Pull request overview
This PR addresses CI build failures related to SVP support by ensuring the SVP enablement flags are passed during the GitHub Actions CMake configure/build steps.
Changes:
- Configure and install the reference
tasecureapiimplementation with-DENABLE_SVP=ON. - Add SVP-related preprocessor definitions to the main project’s CI C/C++ compile flags during configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mhabrat
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous commit did not propagate the ENABLE_SVP flags in config.