Skip to content

RDKEMW-4179 Update usb-ethernet.rules to use USB wifi device IDs from vendor layer#155

Merged
shibu-kv merged 5 commits intodevelopfrom
feature/RDKEMW-4179-test
May 10, 2025
Merged

RDKEMW-4179 Update usb-ethernet.rules to use USB wifi device IDs from vendor layer#155
shibu-kv merged 5 commits intodevelopfrom
feature/RDKEMW-4179-test

Conversation

@nhanasi
Copy link
Copy Markdown
Contributor

@nhanasi nhanasi commented May 9, 2025

Update disableUSBEthernet.sh

@nhanasi nhanasi requested a review from a team as a code owner May 9, 2025 15:01
@nhanasi nhanasi requested a review from a team May 9, 2025 15:01
Comment thread lib/rdk/disableUSBEthernet.sh Outdated
VENDOR_ID=`udevadm info -q all /sys/class/net/wlan0 | grep ID_VENDOR_ID | cut -d " " -f2 | awk -F '=' '{print $2}'`
AUTHORIZED_USB1=`echo $AUTHORIZED_USB_DEVICES | awk -F ":" '{gsub(/"/, ""); print $1}'`
AUTHORIZED_USB2=`echo $AUTHORIZED_USB_DEVICES | awk -F ":" '{gsub(/"/, ""); print $2}'`
echo "Vendor ID of Wifi Driver: $VENDOR_ID"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original script was expecting to echo TRUE/FALSE .

Did we check that these additional echos are breaking the intend of the caller

Copy link
Copy Markdown
Contributor Author

@nhanasi nhanasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed added only for debug purpose

shibu-kv
shibu-kv previously approved these changes May 9, 2025
@shibu-kv shibu-kv merged commit 7b805ac into develop May 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants