XIONE-18284: Need to add monarch process name for core upload#441
XIONE-18284: Need to add monarch process name for core upload#441
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the core upload allowlist to include an additional process so its core dumps are captured/uploaded.
Changes:
- Adds
homescreen_eglto the set of process names that triggerdumpFileand core upload handling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [ "$1" = "NWMgrPlugin" ] || [ "$1" = "nm_event_thrd" ] || | ||
| [ "$1" = "Monitor::IResou" ] || [ "$1" = "DRMSYSTEM" ] || [ "$1" = "HTTPREQUEST_MAN" ] || | ||
| [ "$1" = "civetweb-worker" ] || [ "$1" = "nfrtool" ]; then | ||
| [ "$1" = "civetweb-worker" ] || [ "$1" = "nfrtool" ] || [ "$1" = "homescreen_egl" ]; then |
There was a problem hiding this comment.
PR title mentions adding the "monarch" process name, but the change adds "homescreen_egl". Please confirm the actual process name that should be allowlisted for core upload (and update this condition accordingly) to avoid silently not enabling uploads for the intended process.
| [ "$1" = "civetweb-worker" ] || [ "$1" = "nfrtool" ] || [ "$1" = "homescreen_egl" ]; then | ||
| dumpFile | ||
| exit 0 |
There was a problem hiding this comment.
This allowlist is split between a long chain of OR conditions and the APP_NAMES array below (e.g., "civetweb-worker" is present in both). Adding more entries here increases duplication and the risk of the lists drifting; consider consolidating these process names into a single list/array (or a case pattern) and checking membership in one place.
whiltelist monarch process for coredump