RDKEMW-15490 : Removing reboot script reference from sysint#500
Merged
RDKEMW-15490 : Removing reboot script reference from sysint#500
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes several reboot-related scripts and systemd units from sysint, apparently to eliminate script-based reboot/reboot-info handling.
Changes:
- Removed systemd units for reboot logging (
reboot-logger.service,reboot-reason-logger.service) and previous reboot info update (update-reboot-info.service,update-reboot-info.path). - Removed shell implementations for reboot handling and reboot info updates (
rebootNow.sh,reboot-checker.sh,update_previous_reboot_info.sh).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| systemd_units/update-reboot-info.service | Deleted unit that triggered previous reboot info update script |
| systemd_units/update-reboot-info.path | Deleted path unit that watched /tmp/stt_received to trigger the service |
| systemd_units/reboot-reason-logger.service | Deleted oneshot service that invoked reboot-checker at boot |
| systemd_units/reboot-logger.service | Deleted oneshot shutdown service that invoked reboot-checker at shutdown |
| lib/rdk/update_previous_reboot_info.sh | Deleted previous reboot info processing script |
| lib/rdk/rebootNow.sh | Deleted reboot request script (and its internal fallback logic) |
| lib/rdk/reboot-checker.sh | Deleted boot/shutdown reboot info logger/updater script |
Comments suppressed due to low confidence (1)
lib/rdk/rebootNow.sh:1
- Deleting this script leaves a dangling runtime dependency: the package install still creates a /rebootNow.sh symlink to /lib/rdk/rebootNow.sh (Makefile:86), and multiple remaining scripts invoke /rebootNow.sh (e.g., lib/rdk/utils.sh:65, lib/rdk/factory-reset.sh:200, lib/rdk/userInitiatedFWDnld.sh:451, lib/rdk/warehouse-reset.sh:234). With this file removed, those calls will fail at runtime. Either keep a thin /lib/rdk/rebootNow.sh wrapper (forwarding to the new implementation, e.g. /usr/bin/rebootnow), or update the callers + Makefile symlink to the new path and ensure the legacy /rebootNow.sh entrypoint still exists for compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tdeva14
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.