RDKEMW-17800:gst-cleanup conditions when cdl_flashed_file_name is not present#538
Merged
RDKEMW-17800:gst-cleanup conditions when cdl_flashed_file_name is not present#538
Conversation
… present Reason for change: gstreamer-cleanup is happening on every reboot when /opt/cdl_flashed_file_name is missing. Fixing the issues as well as re-locating gstreamer-cleanup.service file to meta-rdk-video instead of sysint folder Test Procedure: Boot the TV and check for gstreamer-cleanup metrics in rdk_milestones.log Risks: low Signed-off-by: Renuka Varry <rvarry049@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the gstreamer-cleanup systemd unit from the sysint repository, seemingly as part of relocating ownership of this service to another layer (per PR description), intended to stop unintended cleanup behavior on reboot.
Changes:
- Deleted
systemd_units/gstreamer-cleanup.servicefrom sysint.
Comments suppressed due to low confidence (1)
systemd_units/gstreamer-cleanup.service:1
- This PR deletes
systemd_units/gstreamer-cleanup.service, but the PR title/description says it also fixes the cleanup conditions when/opt/cdl_flashed_file_nameis missing. With the unit removed from this repo, that behavioral fix is not present here, and builds that still consume sysint’ssystemd_units/*.service(see Makefile install rule) will no longer ship the cleanup unit at all. Please either (a) include the corrected unit in this PR (or in a clearly linked/required companion PR inmeta-rdk-video) and update the description accordingly, or (b) keep the unit here until the migration is complete to avoid silently dropping the service.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhanasi
approved these changes
May 6, 2026
nhanasi
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: gstreamer-cleanup is happening on every reboot when /opt/cdl_flashed_file_name is missing. Fixing the issues as well as re-locating gstreamer-cleanup.service file to meta-rdk-video instead of sysint folder
Test Procedure: Boot the TV and check for gstreamer-cleanup metrics in rdk_milestones.log
Risks: low