RDKEMW-17125 - Subscribe to NWMgr plugin events from systimemgr by sindhu-krishnan · Pull Request #72 · rdkcentral/systemtimemgr

sindhu-krishnan · 2026-04-30T10:34:30Z

To manage the Deepsleep and Network Outage events in chronyd, it is essential to monitor the Network Up event, as it is relevant to all network-related events.
Subscribe to the "onInternetStatusChange" event of the NetworkMgr plugin and handle the cases according to the specific requirements.

Test Results available in - https://ccp.sys.comcast.net/browse/RDKEMW-17125

- Fix missing WPEFramework includes that caused 'not a namespace-name' and 'JsonObject does not name a type' errors - Move WPEFramework includes exclusively to .cpp to avoid include path issues when header is included from other translation units - Move internal state (controller, thunder_client, m_networkeventsubscribed) to file-scope statics with internal linkage - Convert internal helper functions (subscribeToInternetEvent, unsubscribeFromInternetEvent, plugin_statechange) to static free functions - not part of the class interface - Remove global thunder_ret, use local variable instead - Remove explicit constructor declaration - compiler-generated default is sufficient; destructor handles RAII cleanup on process exit

Two bugs fixed: 1. Use versioned callsign for thunder_client NETWORK_MANAGER_CALLSIGN ('org.rdk.NetworkManager') was used to create the LinkType for subscribing to onInternetStatusChange, but the versioned callsign NETWORK_MANAGER_PLUGIN ('org.rdk.NetworkManager.1') is required for JSONRPC endpoint resolution. Using the unversioned callsign caused ERROR_TIMEDOUT (11) on every subscription attempt. 2. Attempt immediate subscription at startup After subscribing to the controller statechange event, try subscribeToInternetEvent() immediately. If NetworkManager is already active when systimemgr starts or restarts, no statechange event is fired, so the callback-driven subscription never happens. The immediate attempt handles this case; if it fails (plugin not up yet), the statechange callback will retry on the next activation.

…ents Add consistent 'CHRONY:' prefix to all RDK_LOG statements in networkstatussrc.cpp for easy log filtering with: grep CHRONY /opt/logs/systimemgr.log Also remove stale debug log that printed internetStatus before it was populated, which always printed an empty string.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

github-actions · 2026-05-13T11:55:45Z

Code Coverage Summary

                                        Total:|75.5%   759|85.5%  62|    -    0

rdkcmf-jenkins · 2026-05-13T12:02:20Z

+ * after the last NetworkStatusSrc destructor runs. */
+NetworkStatusSrc::NetworkStatusSrc()
+{
+    sharedState(); /* force initialisation — return value intentionally unused */


Coverity Issue - Useless call

Calling "sharedState()" is only useful for its return value, which is ignored.

Medium Impact, CWE-none
USELESS_CALL

github-actions · 2026-05-14T05:54:21Z

Code Coverage Summary

                                        Total:|75.5%   759|85.5%  62|    -    0

rdkcmf-jenkins · 2026-05-14T06:02:41Z

+         * always blocking for the full ACTIVATION_RETRY_INTERVAL_MS. */
+        {
+            std::unique_lock<std::mutex> lock(sharedState().mutex);
+            sharedState().cv.wait_for(lock,


Coverity Issue - Data race condition

A wait is performed without a loop. If there is a spurious wakeup, the condition may not be satisfied. [Note: The source code implementation of the function has been overridden by a builtin model.]

Medium Impact, CWE-none
BAD_CHECK_OF_WAIT_COND

How to fix

Check the wait condition in a loop, with the lock held. The lock must not be released between the condition and the wait.

rdkcmf-jenkins · 2026-05-14T06:02:41Z

+ * after the last NetworkStatusSrc destructor runs. */
+NetworkStatusSrc::NetworkStatusSrc()
+{
+    sharedState(); /* force initialisation — return value intentionally unused */


Coverity Issue - Useless call

Calling "sharedState()" is only useful for its return value, which is ignored.

Medium Impact, CWE-none
USELESS_CALL

github-actions · 2026-05-14T06:32:12Z

Code Coverage Summary

                                        Total:|75.5%   759|85.5%  62|    -    0

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-05-14T06:45:35Z

Code Coverage Summary

                                        Total:|75.5%   759|85.5%  62|    -    0

github-actions · 2026-05-14T06:47:26Z

Code Coverage Summary

                                        Total:|75.5%   759|85.5%  62|    -    0

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-05-14T11:34:47Z

Code Coverage Summary

                                        Total:|75.5%   759|85.5%  62|    -    0

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

tdeva14

LGTM

sindhu-krishnan and others added 30 commits April 22, 2026 14:01

Update systimemgr.cpp

fd92117

Update systimemgr.h

1bbbdda

Update systimemgr.cpp

1665a0d

Create networkstatussrc.cpp

fd24ee8

Create networkstatussrc.h

98c5242

Update networkstatussrc.h

2db9a58

Update systimemgr.cpp

c4711b9

Update Makefile.am

4e9f9cf

Update networkstatussrc.h

3c242e8

Update networkstatussrc.cpp

8abffc8

Update networkstatussrc.h

15e706d

Update networkstatussrc.cpp

d70d1d0

Update networkstatussrc.h

e1e1186

Update networkstatussrc.h

d7a6e53

Update networkstatussrc.h

b2458fc

Update networkstatussrc.h

8c76eb0

Update networkstatussrc.h

ffaa74f

Update networkstatussrc.cpp

8bfa505

Update networkstatussrc.h

bd4a5ae

Update networkstatussrc.h

ddbf4c8

Update networkstatussrc.h

a0b86ec

Update networkstatussrc.h

57c4ee0

Update networkstatussrc.cpp

171710c

Update networkstatussrc.h

2c2ed41

Update networkstatussrc.cpp

eee93da

Update networkstatussrc.h

e539a6a

Update networkstatussrc.cpp

63d04af

rdkcmf-jenkins reviewed May 13, 2026

View reviewed changes

Comment thread systimerfactory/networkstatussrc.cpp Outdated

Update configure.ac

a6592a5

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread test/functional-tests/tests/test_systimemgr_nwstatus.py

Comment thread systimerfactory/networkstatussrc.cpp

Comment thread systimerfactory/networkstatussrc.cpp

Comment thread systimemgr.cpp

rdkcmf-jenkins reviewed May 13, 2026

View reviewed changes

Comment thread systimerfactory/networkstatussrc.cpp Outdated

rdkcmf-jenkins reviewed May 13, 2026

View reviewed changes

Update networkstatussrc.cpp

eabffab

rdkcmf-jenkins reviewed May 14, 2026

View reviewed changes

Update networkstatussrc.cpp

9e7118e

Copilot AI review requested due to automatic review settings May 14, 2026 06:30

Copilot started reviewing on behalf of sindhu-krishnan May 14, 2026 06:30 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread systimerfactory/Makefile.am

Comment thread test/functional-tests/tests/test_systimemgr_nwstatus.py

Comment thread test/functional-tests/tests/test_systimemgr_nwstatus.py

Comment thread systimerfactory/networkstatussrc.cpp Outdated

Comment thread cov_build.sh Outdated

Potential fix for pull request finding

e072c77

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 14, 2026 06:43

Copilot started reviewing on behalf of sindhu-krishnan May 14, 2026 06:43 View session

Potential fix for pull request finding

6276a4d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread test/functional-tests/tests/test_systimemgr_nwstatus.py

Comment thread systimerfactory/networkstatussrc.cpp Outdated

Potential fix for pull request finding

229e0c7

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 14, 2026 11:32

Copilot started reviewing on behalf of sindhu-krishnan May 14, 2026 11:33 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread test/functional-tests/tests/test_systimemgr_nwstatus.py

Comment thread systimerfactory/networkstatussrc.cpp

tdeva14 reviewed May 14, 2026

View reviewed changes

tdeva14 approved these changes May 14, 2026

View reviewed changes

tdeva14 merged commit 82e5dea into develop May 14, 2026
16 checks passed

github-actions Bot locked and limited conversation to collaborators May 14, 2026

Conversation

sindhu-krishnan commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 13, 2026

Code Coverage Summary

Uh oh!

Uh oh!

rdkcmf-jenkins May 13, 2026

Choose a reason for hiding this comment

Coverity Issue - Useless call

Uh oh!

github-actions Bot commented May 14, 2026

Code Coverage Summary

Uh oh!

rdkcmf-jenkins May 14, 2026

Choose a reason for hiding this comment

Coverity Issue - Data race condition

How to fix

Uh oh!

rdkcmf-jenkins May 14, 2026

Choose a reason for hiding this comment

Coverity Issue - Useless call

Uh oh!

github-actions Bot commented May 14, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

Code Coverage Summary

Uh oh!

github-actions Bot commented May 14, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

tdeva14 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sindhu-krishnan commented Apr 30, 2026 •

edited

Loading