Skip to content

RDKEMW-15246 : Chrony Enhancements#79

Merged
tdeva14 merged 11 commits into
developfrom
ntp-sync
May 22, 2026
Merged

RDKEMW-15246 : Chrony Enhancements#79
tdeva14 merged 11 commits into
developfrom
ntp-sync

Conversation

@sindhu-krishnan
Copy link
Copy Markdown
Contributor

Integrate Unified NTP convergence time logic with systimemgr

@sindhu-krishnan sindhu-krishnan requested a review from a team as a code owner May 21, 2026 11:18
Copilot AI review requested due to automatic review settings May 21, 2026 11:18
@github-actions
Copy link
Copy Markdown

Code Coverage Summary

                                        Total:|72.1%   798|82.8%  64|    -    0

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an NTP synchronisation monitoring path to systimemgr intended to capture unified NTP convergence timing when Chrony RFC mode is enabled.

Changes:

  • Adds a new ntpSyncMonitor thread that polls adjtimex() once per second to detect when the kernel clock becomes NTP-synchronised.
  • On sync detection, writes marker/status files (e.g., /tmp/clock-event, /tmp/systimemgr/ntp, /tmp/ntp_status).
  • Wires the new thread into the existing SysTimeMgr::run() lifecycle (start + join/detach).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
systimemgr.h Declares the new NTP sync monitor thread entrypoint and worker method.
systimemgr.cpp Implements the NTP sync polling loop and integrates the new thread into the run lifecycle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread systimemgr.cpp Outdated
Comment thread systimemgr.cpp Outdated
Comment thread systimemgr.cpp
Comment thread systimemgr.cpp Outdated
Comment thread systimemgr.cpp
@github-actions
Copy link
Copy Markdown

Code Coverage Summary

                                        Total:|71.4%   805|82.8%  64|    -    0

Copilot AI review requested due to automatic review settings May 21, 2026 18:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread systimemgr.cpp Outdated
Comment thread systimemgr.cpp
Comment thread systimemgr.cpp
Comment thread systimemgr.cpp
Copilot AI review requested due to automatic review settings May 21, 2026 19:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread systimemgr.cpp Outdated
Comment thread systimemgr.cpp
Comment thread systimemgr.cpp
Comment thread systimemgr.cpp
@github-actions
Copy link
Copy Markdown

Code Coverage Summary

                                        Total:|71.4%   805|82.8%  64|    -    0

Copy link
Copy Markdown
Contributor

@tdeva14 tdeva14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdeva14 tdeva14 merged commit 588dfe2 into develop May 22, 2026
13 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants