Conversation
Code Coverage Summary |
There was a problem hiding this comment.
Pull request overview
This PR adds an NTP synchronisation monitoring path to systimemgr intended to capture unified NTP convergence timing when Chrony RFC mode is enabled.
Changes:
- Adds a new
ntpSyncMonitorthread that pollsadjtimex()once per second to detect when the kernel clock becomes NTP-synchronised. - On sync detection, writes marker/status files (e.g.,
/tmp/clock-event,/tmp/systimemgr/ntp,/tmp/ntp_status). - Wires the new thread into the existing
SysTimeMgr::run()lifecycle (start + join/detach).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| systimemgr.h | Declares the new NTP sync monitor thread entrypoint and worker method. |
| systimemgr.cpp | Implements the NTP sync polling loop and integrates the new thread into the run lifecycle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage Summary |
Code Coverage Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate Unified NTP convergence time logic with systimemgr