RDK-58398:Fix curl dependency for some API's#136
Merged
Conversation
Reason for change: curl_url_strerror() is available from 7.80.0 added logic to check the version for using certain API's Test Procedure: Verify that the URL is using Risks: Low
shibu-kv
requested changes
Jul 21, 2025
source/xconf-client/xconfclient.c
Outdated
| #endif | ||
|
|
||
|
|
||
| #if LIBCURL_VERSION_NUM >= 0x075000 /* 7.80.0 */ |
Contributor
There was a problem hiding this comment.
We can limit the logging to error code alone if the curl_url_strerror is only available in certain versions and higher up.
Contributor
Author
There was a problem hiding this comment.
Have commented the code.
|
|
||
| #if LIBCURL_VERSION_NUM >= 0x075000 /* 7.80.0 */ | ||
| #define T2_CURL_APPENDREQUEST_ERROR(rc) \ | ||
| do { \ |
Contributor
There was a problem hiding this comment.
Not necessarily needed in this context to wrap in do while construct as we have only one if check here. But considering the defensive coding techniques, is okay to retain.
Reason for change: Adress review comments, avoid version dependency for the macro. Test Procedure: Verify that the URL is using Risks: Low
shibu-kv
previously approved these changes
Jul 21, 2025
Reason for change: Adress review comments, avoid version dependency for the macro. Test Procedure: Verify that the URL is using Risks: Low
shibu-kv
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: curl_url_strerror() is available from 7.80.0 added logic to check the version for using certain curl API's
ref : https://curl.se/changes.html#7_80_0[curl_url_strerror()](https://curl.se/bug/?i=7605)
Test Procedure: Verify that the URL is using
Risks: Low