RDK-57609: [Telemetry]: Target 75% L1 Coverage to Improve Quality and Delivery Confidence#147
Merged
RDK-57609: [Telemetry]: Target 75% L1 Coverage to Improve Quality and Delivery Confidence#147
Conversation
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
Contributor
Coverity Issue - Data race conditionAccessing "profile->grepSeekProfile->execCounter" without holding lock "plMutex". Elsewhere, "_GrepSeekProfile.execCounter" is written to with "plMutex" held 2 out of 2 times. Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Contributor
Coverity Issue - Check of thread-shared field evades lock acquisitionThread1 sets "initialized" to a new value. Now the two threads have an inconsistent view of "initialized" and updates to fields correlated with "initialized" may be lost. High Impact, CWE-543 How to fixGuard the modification of "initialized" and the read used to decide whether to modify "initialized" with the same set of locks. Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
source/t2parser/t2parser.c
Outdated
| gMarker->skipFreq = skipFreq; | ||
| gMarker->firstSeekFromEOF = firstSeekFromEOF; | ||
| T2Info("%s %d\n", __FUNCTION__, __LINE__); | ||
| if(strncmp("top_log.txt", fileName, sizeof("top_log.txt")) == 0) |
Contributor
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Dereference after null check
Passing null pointer "fileName" to "strncmp", which dereferences it.
Medium Impact, CWE-476
FORWARD_NULL
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
Contributor
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
Contributor
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
Contributor
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
Contributor
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
…etry into topic/RDK-57609
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
…etry into topic/RDK-57609
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
… Delivery Confidence Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>
shibu-kv
approved these changes
Aug 29, 2025
Contributor
|
FOSSID matches are false matches. Hence merging the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.