Skip to content

RDKB-63722: Build fix for ssl crypto error in platforms with lower ssl version#291

Merged
shibu-kv merged 4 commits intodevelopfrom
topic/build_fix
Mar 19, 2026
Merged

RDKB-63722: Build fix for ssl crypto error in platforms with lower ssl version#291
shibu-kv merged 4 commits intodevelopfrom
topic/build_fix

Conversation

@yogeswaransky
Copy link
Contributor

@yogeswaransky yogeswaransky commented Mar 19, 2026

Reason for change: Compilation Error resolved in XE2V2 Build because this device build was using an older version probable 1.0.x. . Actually OPENSSL_thread_stop() was introduced only in OpenSSL 1.1.0. We used this api for release all OpenSSL per-thread state (ERR stack, cached allocations) at the end of the worker thread. Its compatible with all RDKB device except
Test Procedure: please refer the ticket comments
Risks: Medium

@yogeswaransky yogeswaransky requested a review from a team as a code owner March 19, 2026 05:20
Copilot AI review requested due to automatic review settings March 19, 2026 05:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a build failure related to OpenSSL “crypto” symbols by adding the appropriate OpenSSL header include in the HTTP multi-curl implementation.

Changes:

  • Add #include <openssl/crypto.h> to ensure OpenSSL crypto APIs used in this file are properly declared during compilation.

Copilot AI review requested due to automatic review settings March 19, 2026 06:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to resolve an OpenSSL-related build issue in the HTTP multi-curl implementation by adjusting OpenSSL header usage and per-thread cleanup logic.

Changes:

  • Added an OpenSSL header include (<openssl/crypto.h>).
  • Modified OpenSSL per-thread cleanup in http_pool_get() by disabling OPENSSL_thread_stop() and calling ERR_remove_thread_state(NULL) instead.

Copilot AI review requested due to automatic review settings March 19, 2026 07:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an SSL/OpenSSL build issue by making OpenSSL per-thread cleanup compatible across OpenSSL versions.

Changes:

  • Added <openssl/crypto.h> include to support OpenSSL thread cleanup APIs.
  • Wrapped OPENSSL_thread_stop() behind an OpenSSL version check and added a fallback to ERR_remove_thread_state(NULL) for older OpenSSL.
  • Adjusted per-thread OpenSSL cleanup in both http_pool_get and http_pool_post.

shibu-kv
shibu-kv previously approved these changes Mar 19, 2026
@yogeswaransky yogeswaransky changed the title RDKB-63722: Build fix for ssl crypto error RDKB-63722: Build fix for ssl crypto error in platforms with lower ssl version Mar 19, 2026
@shibu-kv shibu-kv merged commit fc678f5 into develop Mar 19, 2026
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants