RDKB-63722: Build fix for ssl crypto error in platforms with lower ssl version#291
Merged
RDKB-63722: Build fix for ssl crypto error in platforms with lower ssl version#291
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a build failure related to OpenSSL “crypto” symbols by adding the appropriate OpenSSL header include in the HTTP multi-curl implementation.
Changes:
- Add
#include <openssl/crypto.h>to ensure OpenSSL crypto APIs used in this file are properly declared during compilation.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve an OpenSSL-related build issue in the HTTP multi-curl implementation by adjusting OpenSSL header usage and per-thread cleanup logic.
Changes:
- Added an OpenSSL header include (
<openssl/crypto.h>). - Modified OpenSSL per-thread cleanup in
http_pool_get()by disablingOPENSSL_thread_stop()and callingERR_remove_thread_state(NULL)instead.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an SSL/OpenSSL build issue by making OpenSSL per-thread cleanup compatible across OpenSSL versions.
Changes:
- Added
<openssl/crypto.h>include to support OpenSSL thread cleanup APIs. - Wrapped
OPENSSL_thread_stop()behind an OpenSSL version check and added a fallback toERR_remove_thread_state(NULL)for older OpenSSL. - Adjusted per-thread OpenSSL cleanup in both
http_pool_getandhttp_pool_post.
shibu-kv
previously approved these changes
Mar 19, 2026
shibu-kv
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Compilation Error resolved in XE2V2 Build because this device build was using an older version probable 1.0.x. . Actually OPENSSL_thread_stop() was introduced only in OpenSSL 1.1.0. We used this api for release all OpenSSL per-thread state (ERR stack, cached allocations) at the end of the worker thread. Its compatible with all RDKB device except
Test Procedure: please refer the ticket comments
Risks: Medium