RDKEMW-12350: Add unit tests for timeZoneDST fallback path in getTimezone() by Copilot · Pull Request #329 · rdkcentral/telemetry

Copilot · 2026-04-14T15:54:13Z

Remove the spurious .WillOnce(Return(EOF)) from SetupReachTimeZoneDSTFallback in xconfclientTest.cpp — getBuildType breaks out of the fscanf loop as soon as it finds "BUILD_TYPE", so fscanf is only called once, not twice

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/2b39401a-79a0-4d6a-a81f-523a6997a872 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/7f6ea2d9-36fa-4120-a7dc-e7bfe71e9f8a Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Copilot

Pull request overview

Adds Google Test coverage for the getTimezone() fallback path that reads /opt/persistent/timeZoneDST (reached after the JSON retry loop), exercised indirectly via appendRequestParams().

Changes:

Add 5 new unit tests covering timeZoneDST fallback failure modes and a success case.
Add a shared test helper to drive execution into the fallback path.
Adjust GitHub Actions PR branch filters for L1/L2 workflows.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File	Description
`source/test/xconf-client/xconfclientTest.cpp`	Adds tests and a helper to force `getTimezone()` into the `/opt/persistent/timeZoneDST` fallback path.
`.github/workflows/L1-tests.yml`	Updates which target branches trigger the L1 workflow on pull requests.
`.github/workflows/L2-tests.yml`	Updates which target branches trigger the L2 workflow on pull requests.

Copilot · 2026-04-14T17:06:55Z

+    curl_url_set(requestURL, CURLUPART_URL,
+                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
+    EXPECT_EQ(T2ERROR_FAILURE, appendRequestParams(requestURL));
+    curl_free(requestURL);


requestURL is a CURLU* created by curl_url(), which should be released with curl_url_cleanup(). Using curl_free() on a CURLU* is not the documented cleanup API and can lead to leaks or undefined behavior.

Copilot · 2026-04-14T17:06:56Z

+    curl_url_set(requestURL, CURLUPART_URL,
+                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
+    EXPECT_EQ(T2ERROR_FAILURE, appendRequestParams(requestURL));
+    curl_free(requestURL);


requestURL is a CURLU* created by curl_url(), which should be released with curl_url_cleanup(). Using curl_free() on a CURLU* is not the documented cleanup API and can lead to leaks or undefined behavior.

Copilot · 2026-04-14T17:06:56Z

+    curl_url_set(requestURL, CURLUPART_URL,
+                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
+    EXPECT_EQ(T2ERROR_SUCCESS, appendRequestParams(requestURL));
+    curl_free(requestURL);


requestURL is a CURLU* created by curl_url(), which should be released with curl_url_cleanup(). Using curl_free() on a CURLU* is not the documented cleanup API and can lead to leaks or undefined behavior.

Suggested change

curl_free(requestURL);

curl_url_cleanup(requestURL);

Copilot · 2026-04-14T17:06:56Z

+            buf[10] = '\0';
+            return 1;
+        }))
+        .WillOnce(Return(0));


The comment says the second fscanf call "signals end-of-file", but the mock returns 0. In getTimezone() the loop condition is fscanf(...) == 1, so returning EOF would better reflect end-of-file and keep the comment accurate (or update the comment to match the 0 return).

Suggested change

.WillOnce(Return(0));

.WillOnce(Return(EOF));

Copilot · 2026-04-14T17:06:57Z

+    EXPECT_CALL(*g_fileIOMock, fscanf(devicePropsHandle, _, _))
+        .WillOnce(Invoke([](FILE*, const char*, va_list args) -> int {
+            char* buf = va_arg(args, char*);
+            strncpy(buf, "BUILD_TYPE=PROD", 254);
+            buf[254] = '\0';
+            return 1;
+        }))
+        .WillOnce(Return(EOF));
+


SetupReachTimeZoneDSTFallback configures fscanf(devicePropsHandle, ...) to be called twice (second call returns EOF). In getBuildType() the loop breaks as soon as "BUILD_TYPE" is found, so with the mocked buffer containing "BUILD_TYPE=PROD" it will typically call fscanf only once. This makes the expectation overspecified and can cause these tests to fail; adjust the expectation to match a single call or allow additional calls only when the loop continues (e.g., by using a repeated EOF fallback instead of requiring a second call).

Copilot · 2026-04-14T17:06:57Z

+    curl_url_set(requestURL, CURLUPART_URL,
+                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
+    EXPECT_EQ(T2ERROR_FAILURE, appendRequestParams(requestURL));
+    curl_free(requestURL);


requestURL is a CURLU* created by curl_url(), which should be released with curl_url_cleanup(). Using curl_free() on a CURLU* is not the documented cleanup API and can lead to leaks or undefined behavior.

Copilot · 2026-04-14T17:06:57Z

+    curl_url_set(requestURL, CURLUPART_URL,
+                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
+    EXPECT_EQ(T2ERROR_FAILURE, appendRequestParams(requestURL));
+    curl_free(requestURL);


requestURL is a CURLU* created by curl_url(), which should be released with curl_url_cleanup(). Using curl_free() on a CURLU* is not the documented cleanup API and can lead to leaks or undefined behavior.

Copilot · 2026-04-14T17:06:57Z

 on:
  pull_request:
-    branches: [ develop, support/1.8 ]
+    branches: [ develop ]


Changing the pull_request.branches filter from [ develop, support/1.8 ] to only [ develop ] means L2 integration tests will no longer run for PRs targeting support/1.8. If support/1.8 PRs are still expected to be validated by L2 in this repo, this should be kept (or replaced with the desired set).

Suggested change

branches: [ develop ]

branches: [ develop, support/1.8 ]

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/03d1c8d7-2587-443b-bbe5-50a78ff7f073 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

…o break in getBuildType Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/d94df585-444b-4056-a136-bc1f7415c614 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Initial plan

aa88d6d

Copilot AI assigned Copilot and yogeswaransky Apr 14, 2026

Copilot AI mentioned this pull request Apr 14, 2026

RDKEMW-12350: Fix uninitialized missing error checks in timeZoneDST fallback path #324

Open

Copilot started work on behalf of yogeswaransky April 14, 2026 15:54 View session

Add unit tests for timeZoneDST fallback path in getTimezone()

0ceb491

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/2b39401a-79a0-4d6a-a81f-523a6997a872 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix uninitialized missing error checks in timeZoneDST fallback path~~ RDKEMW-12350: Add unit tests for timeZoneDST fallback path in getTimezone() Apr 14, 2026

Copilot finished work on behalf of yogeswaransky April 14, 2026 16:18

Copilot AI requested a review from yogeswaransky April 14, 2026 16:18

Copilot started work on behalf of yogeswaransky April 14, 2026 16:54 View session

Revert build infrastructure changes, keep only test and source changes

46f82cd

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/7f6ea2d9-36fa-4120-a7dc-e7bfe71e9f8a Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Copilot finished work on behalf of yogeswaransky April 14, 2026 16:57

Update L1-tests.yml

d10e308

yogeswaransky marked this pull request as ready for review April 14, 2026 17:01

yogeswaransky requested a review from a team as a code owner April 14, 2026 17:01

Copilot AI review requested due to automatic review settings April 14, 2026 17:01

Copilot started reviewing on behalf of yogeswaransky April 14, 2026 17:02 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Copilot started work on behalf of yogeswaransky April 16, 2026 07:12 View session

Fix unqualified Invoke in getTimezone_timeZoneDST_valid_timezone test

e9e1117

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/03d1c8d7-2587-443b-bbe5-50a78ff7f073 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Copilot finished work on behalf of yogeswaransky April 16, 2026 07:15

Copilot started work on behalf of yogeswaransky April 16, 2026 08:54 View session

Fix SetupReachTimeZoneDSTFallback: fscanf called once not twice due t…

0bbe815

…o break in getBuildType Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/d94df585-444b-4056-a136-bc1f7415c614 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot April 16, 2026 08:56

Copilot finished work on behalf of yogeswaransky April 16, 2026 08:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDKEMW-12350: Add unit tests for timeZoneDST fallback path in getTimezone()#329

RDKEMW-12350: Add unit tests for timeZoneDST fallback path in getTimezone()#329
Copilot wants to merge 6 commits intocopilot/improve-zone-null-checksfrom
copilot/sub-pr-324

Copilot AI commented Apr 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 14, 2026 •

edited

Loading