RDKB-59420: Minor update to Previous Logs lookup feature#64
Merged
Conversation
f011d32 to
00e0f03
Compare
Contributor
Coverity Issue - Check of thread-shared field evades lock acquisitionThread1 sets "initialized" to a new value. Now the two threads have an inconsistent view of "initialized" and updates to fields correlated with "initialized" may be lost. High Impact, CWE-543 How to fixGuard the modification of "initialized" and the read used to decide whether to modify "initialized" with the same set of locks. Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Reason for change: Fix syntax error and logic to report generation during previous seek Test Procedure: There should not be any regression. Risks: Low
00e0f03 to
23815b4
Compare
shibu-kv
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fix syntax error and logic to report generation during previous seek
Test Procedure: There should not be any regression.
Risks: Low