RDKB 63035 - HotSPot - IPv6 connectivity from LAN clients is not working #174

rirfha948 · 2026-01-14T10:16:32Z

Reason for change:
DROP rules has been added only if CURRENT WAN IFNAME is same as DEFAULT WAN IFNAME

Priority: P1
1.Is this a Bug or a User Story (US)?

This is a Bug - RDKB-63035

If it is a User Story:
Have all dependent PRs from other components been listed (if any)?
Does the commit message include both the User Story ticket and the Subtask ticket?
Will be all changes related to the User Story squashed and merged in a single commit?
Has the PR been raised only after completing all changes for the User Story (no partial changes)?
Has code development for the User Story been completed?
If yes, has the Gerrit topic or list of all dependent PRs across components (including meta-layer changes) been shared?

NOT APPLICABLE

Is there a validation log available in the Jira ticket for verifying builds with the updated generic-srcrev.inc across all platforms?

Yes

If yes, have the links to validation comments been shared?
Validation logs have been attached
image

Jenkins link:
https://gerrit.teamccp.com/#/c/943667/

Verification Build

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

source/firewall/firewall_ipv6.c

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

rdkcmf-jenkins · 2026-01-16T05:01:40Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/utopia/174/rdkb/components/opensource/ccsp/Utopia
Commit: 30e8353

Report detail: gist'

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

rdkcmf-jenkins · 2026-01-16T06:46:29Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/utopia/174/rdkb/components/opensource/ccsp/Utopia
Commit: e0fd784

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T06:49:17Z

source/service_routed/service_routed.c

+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);
+	sysevent_get(sr->sefd, sr->setok, "lan_prefix", prefix, sizeof(prefix));


Inconsistent indentation: lines 2457-2458, 2462-2463 use tabs while the surrounding code uses spaces. This creates mixed indentation which can cause issues with different editor settings and violates coding standards. Replace tabs with spaces to match the indentation style of the rest of the file.

Copilot · 2026-01-16T06:49:17Z

source/service_routed/service_routed.c

+    DEG_PRINT1("63035 - Debug current_wan_ifname:%s hotspot_wan_ifname:%s \n", wan_interface, hotspot_wan_ifname);
+    if (strcmp(wan_interface, hotspot_wan_ifname) == 0)
+    {
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);
+	sysevent_get(sr->sefd, sr->setok, "lan_prefix", prefix, sizeof(prefix));
+    } 
+    else
+    {
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Debug statements contain the bug ticket number '63035' which makes them temporary/issue-specific rather than general-purpose logging. These debug statements should either be removed before merging or rewritten to be generic debug messages without the ticket number, as they will become obsolete after the bug is resolved.

Suggested change

DEG_PRINT1("63035 - Debug current_wan_ifname:%s hotspot_wan_ifname:%s \n", wan_interface, hotspot_wan_ifname);

if (strcmp(wan_interface, hotspot_wan_ifname) == 0)

{

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

sysevent_get(sr->sefd, sr->setok, "lan_prefix", prefix, sizeof(prefix));

}

else

{

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

DEG_PRINT1("Debug current_wan_ifname:%s hotspot_wan_ifname:%s \n", wan_interface, hotspot_wan_ifname);

if (strcmp(wan_interface, hotspot_wan_ifname) == 0)

{

DEG_PRINT1("Line:%d\n", __LINE__);

sysevent_get(sr->sefd, sr->setok, "lan_prefix", prefix, sizeof(prefix));

}

else

{

DEG_PRINT1("Line:%d\n", __LINE__);

Copilot · 2026-01-16T06:49:18Z

source/service_routed/service_routed.c

+    DEG_PRINT1("63035 - Debug log prefix:%s pref_rx:%s out:%s\n",prefix,pref_rx,out);
    if ( strlen(pref_rx) != 0 )
    {
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Multiple debug statements throughout the function (lines 2457, 2462, 2478, 2483, 2489, 2512, 2521, 2535, 2547, 2549) only print line numbers without meaningful context. These provide limited debugging value and should either be removed or enhanced with descriptive messages about what operation is being performed.

source/service_routed/service_routed.c

source/firewall/firewall_ipv6.c

source/service_routed/service_routed.c

Copilot · 2026-01-16T06:49:19Z

source/service_routed/service_routed.c


                if (prefix[0] != '\0' && strlen(prefix) != 0 )
                {
+	    DEG_PRINT1("63035 - Line:%d prefix:%s\n", __LINE__, prefix);


Inconsistent indentation: line 2541 uses tabs while surrounding code uses spaces. This should use consistent spacing to match the file's indentation style.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-01-16T07:00:14Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/utopia/174/rdkb/components/opensource/ccsp/Utopia
Commit: f677bf7

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T07:01:58Z

source/service_routed/service_routed.c

+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);
+	sysevent_get(sr->sefd, sr->setok, "lan_prefix", prefix, sizeof(prefix));
+    } 
+    else
+    {
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);
+	sysevent_get(sr->sefd, sr->setok, "ipv6_prefix_ula", prefix, sizeof(prefix));


Inconsistent indentation: The code inside the if-else blocks uses tabs that appear misaligned. The DEG_PRINT1 statements and sysevent_get calls should be consistently indented with spaces or tabs to match the rest of the codebase. The current mix creates readability issues.

Suggested change

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

sysevent_get(sr->sefd, sr->setok, "lan_prefix", prefix, sizeof(prefix));

}

else

{

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

sysevent_get(sr->sefd, sr->setok, "ipv6_prefix_ula", prefix, sizeof(prefix));

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

sysevent_get(sr->sefd, sr->setok, "lan_prefix", prefix, sizeof(prefix));

}

else

{

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

sysevent_get(sr->sefd, sr->setok, "ipv6_prefix_ula", prefix, sizeof(prefix));

source/firewall/firewall_ipv6.c

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

rdkcmf-jenkins · 2026-01-16T10:10:15Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/utopia/174/rdkb/components/opensource/ccsp/Utopia
Commit: 7c3d90d

Report detail: gist'

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

rdkcmf-jenkins · 2026-01-16T10:44:46Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/utopia/174/rdkb/components/opensource/ccsp/Utopia
Commit: ebd28de

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T10:47:10Z

source/service_routed/service_routed.c

    }
    else
    {
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Excessive debug logging has been added with ticket-specific prefixes (63035). These debug statements should either be removed before merging or converted to use proper logging levels. Debug prints with line numbers provide minimal value and clutter the code. Consider keeping only the essential log statements with meaningful context.

Copilot · 2026-01-16T10:47:10Z

source/service_routed/service_routed.c

+	DEG_PRINT1("63035 - Line:%d\n", __LINE__);
+	if ((IsHotspotActive) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+	{
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Excessive debug logging has been added with ticket-specific prefixes (63035). These debug statements should either be removed before merging or converted to use proper logging levels. Debug prints with line numbers provide minimal value and clutter the code. Consider keeping only the essential log statements with meaningful context.

Copilot · 2026-01-16T10:47:10Z

source/service_routed/service_routed.c

+	} 
+	else  
+	{
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Excessive debug logging has been added with ticket-specific prefixes (63035). These debug statements should either be removed before merging or converted to use proper logging levels. Debug prints with line numbers provide minimal value and clutter the code. Consider keeping only the essential log statements with meaningful context.

Copilot · 2026-01-16T10:47:10Z

source/service_routed/service_routed.c


        sysevent_set(sr->sefd, sr->setok, "lan_ipaddr_v6",token, 0);
        */
+	    DEG_PRINT1("63035 - Line:%d, lan_if:%s, token:%s, pref_len:%d\n", __LINE__, lan_if,token,pref_len);


Excessive debug logging has been added with ticket-specific prefixes (63035). These debug statements should either be removed before merging or converted to use proper logging levels. Debug prints with line numbers provide minimal value and clutter the code. Consider keeping only the essential log statements with meaningful context.

Copilot · 2026-01-16T10:47:10Z

source/service_routed/service_routed.c


    if(!strncmp(out,"true",strlen(out)))
    {
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Excessive debug logging has been added with ticket-specific prefixes (63035). These debug statements should either be removed before merging or converted to use proper logging levels. Debug prints with line numbers provide minimal value and clutter the code. Consider keeping only the essential log statements with meaningful context.

Copilot · 2026-01-16T10:47:11Z

source/service_routed/service_routed.c

            pt = out;
            while((token = strtok_r(pt, ",", &pt)))
            {
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Excessive debug logging has been added with ticket-specific prefixes (63035). These debug statements should either be removed before merging or converted to use proper logging levels. Debug prints with line numbers provide minimal value and clutter the code. Consider keeping only the essential log statements with meaningful context.

Copilot · 2026-01-16T10:47:11Z

source/service_routed/service_routed.c

                }
                memset(prefix,0,sizeof(prefix));

+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Excessive debug logging has been added with ticket-specific prefixes (63035). These debug statements should either be removed before merging or converted to use proper logging levels. Debug prints with line numbers provide minimal value and clutter the code. Consider keeping only the essential log statements with meaningful context.

Copilot · 2026-01-16T10:47:11Z

source/service_routed/service_routed.c

+	    DEG_PRINT1("63035 - Line:%d prefix:%s\n", __LINE__, prefix);
                        SetV6Route(interface_name,prefix);
                        token_pref = strtok(prefix,"/");
+	    DEG_PRINT1("63035 - Line:%d, interface_name:%s, token_pref:%s, pref_len:%d\n", __LINE__, interface_name, token_pref,pref_len);
                        AssignIpv6Addr(interface_name,token_pref,pref_len);
                }
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);
            }
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Excessive debug logging has been added with ticket-specific prefixes (63035). These debug statements should either be removed before merging or converted to use proper logging levels. Debug prints with line numbers provide minimal value and clutter the code. Consider keeping only the essential log statements with meaningful context.

source/service_routed/service_routed.c

Copilot · 2026-01-16T10:47:12Z

source/service_routed/service_routed.c

+    sysevent_get(sr->sefd, sr->setok, "current_wan_ifname", wan_interface, sizeof(wan_interface));
+
+    DEG_PRINT1("63035 - Debug current_wan_ifname:%s mesh_wan_ifname:%s \n", wan_interface, mesh_wan_ifname);
+    if ((IsHotspotActive) || (strcmp(wan_interface, mesh_wan_ifname) == 0))


The strcmp will crash if mesh_wan_ifname is empty (which happens when PSM_VALUE_GET_STRING fails at line 2447-2452). Either check that mesh_wan_ifname is non-empty before calling strcmp, or ensure the entire condition short-circuits properly when wan_interface is empty.

Suggested change

if ((IsHotspotActive) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

if (IsHotspotActive ||

(mesh_wan_ifname && mesh_wan_ifname[0] != '\0' &&

wan_interface[0] != '\0' &&

strcmp(wan_interface, mesh_wan_ifname) == 0))

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T11:45:41Z

source/service_routed/service_routed.c

+    DEG_PRINT1("63035 - Debug current_wan_ifname:%s mesh_wan_ifname:%s \n", wan_interface, mesh_wan_ifname);
+    if (IsHotspotActive() || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+    {
+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);


Excessive debug logging referencing ticket number RDKB-63035 should be removed or reduced before merging to production. Debug statements that only print line numbers provide minimal value and clutter the code. Consider removing most of these debug statements and keeping only the informative ones (lines 2456, 2474, 2514, 2549, 2552) that show actual variable values.

Suggested change

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

Copilot · 2026-01-16T11:45:42Z

source/service_routed/service_routed.c

+	    DEG_PRINT1("63035 - Line:%d\n", __LINE__);
+	sysevent_get(sr->sefd, sr->setok, "lan_prefix", hotspot_lan_prefix, sizeof(hotspot_lan_prefix));


Inconsistent indentation: Line 2460 uses a mix of tabs and spaces that doesn't align with line 2459. Both lines should use consistent indentation (4 spaces based on surrounding code).

Suggested change

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

sysevent_get(sr->sefd, sr->setok, "lan_prefix", hotspot_lan_prefix, sizeof(hotspot_lan_prefix));

DEG_PRINT1("63035 - Line:%d\n", __LINE__);

sysevent_get(sr->sefd, sr->setok, "lan_prefix", hotspot_lan_prefix, sizeof(hotspot_lan_prefix));

source/service_routed/service_routed.c

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T14:58:51Z

source/service_routed/service_routed.c

+
+    if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+    {
+	sysevent_get(sr->sefd, sr->setok, "lan_prefix", hotspot_lan_prefix, sizeof(hotspot_lan_prefix));


Inconsistent indentation with tabs instead of spaces. Line 2465 uses tabs for indentation while the surrounding code uses spaces. This should be consistent with the rest of the file's indentation style.

Suggested change

sysevent_get(sr->sefd, sr->setok, "lan_prefix", hotspot_lan_prefix, sizeof(hotspot_lan_prefix));

sysevent_get(sr->sefd, sr->setok, "lan_prefix", hotspot_lan_prefix, sizeof(hotspot_lan_prefix));

Copilot · 2026-01-16T14:58:51Z

source/service_routed/service_routed.c

+	if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+	{
+	    SetV6Route(lan_if,hotspot_lan_prefix);
+	} 
+	else  
+	{
+	    SetV6Route(lan_if,prefix);
+	}
+	char *token;


Logic error: code at lines 2490-2497 should be wrapped within WAN_FAILOVER_SUPPORTED ifdef block. When WAN_FAILOVER_SUPPORTED is not defined, the variables mesh_wan_ifname, hotspot_wan_ifname, and wan_interface are initialized to empty strings. This causes the strcmp at line 2490 to evaluate to true (empty string equals empty string), leading to SetV6Route being called with an empty hotspot_lan_prefix. This is likely not the intended behavior. Either wrap this conditional block in WAN_FAILOVER_SUPPORTED or add a check to ensure these variables are not empty before comparing.

Suggested change

if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

{

SetV6Route(lan_if,hotspot_lan_prefix);

}

else

{

SetV6Route(lan_if,prefix);

}

char *token;

#ifdef WAN_FAILOVER_SUPPORTED

if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

{

SetV6Route(lan_if,hotspot_lan_prefix);

}

else

{

SetV6Route(lan_if,prefix);

}

#else

SetV6Route(lan_if,prefix);

#endif

char *token;

Copilot · 2026-01-16T14:58:51Z

source/service_routed/service_routed.c

+	if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+	{
+	    SetV6Route(lan_if,hotspot_lan_prefix);
+	} 
+	else  
+	{
+	    SetV6Route(lan_if,prefix);
+	}
+	char *token;


Inconsistent indentation with tabs instead of spaces. Lines 2490-2497 use tabs for indentation while the surrounding code uses spaces. This should be consistent with the rest of the file's indentation style.

Suggested change

if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

{

SetV6Route(lan_if,hotspot_lan_prefix);

}

else

{

SetV6Route(lan_if,prefix);

}

char *token;

if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

{

SetV6Route(lan_if,hotspot_lan_prefix);

}

else

{

SetV6Route(lan_if,prefix);

}

char *token;

Copilot · 2026-01-16T14:58:52Z

source/service_routed/service_routed.c

+	{
+	    SetV6Route(lan_if,prefix);
+	}
+	char *token;


Inconsistent indentation with tabs instead of spaces. Line 2498 uses tabs for indentation while the surrounding code uses spaces. This should be consistent with the rest of the file's indentation style.

Suggested change

char *token;

char *token;

snayak002c · 2026-01-16T18:31:03Z

source/service_routed/service_routed.c

    {
-        SetV6Route(lan_if,prefix);
-        char *token;
+	if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))


we need to add both the routes.

snayak002c · 2026-01-16T18:31:34Z

source/service_routed/service_routed.c

+
+    if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+    {
+	sysevent_get(sr->sefd, sr->setok, "lan_prefix", hotspot_lan_prefix, sizeof(hotspot_lan_prefix));


rename this variable , this is not the prefix received from hotspot wan. keep something like prev_lan_global_prefix

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-20T03:00:05Z

source/service_routed/service_routed.c

+	if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+	{
+	    SetV6Route(lan_if,prev_lan_global_prefix);
+	} 
+	SetV6Route(lan_if,prefix);
+	char *token;


The same strcmp condition from lines 2463 and 2490 is duplicated. If the condition is true at line 2463, it will still be true at line 2490. Consider refactoring to use a boolean variable set once after the first check (line 2463) to avoid repeating the comparison logic and improve code maintainability.

Suggested change

if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

{

SetV6Route(lan_if,prev_lan_global_prefix);

}

SetV6Route(lan_if,prefix);

char *token;

bool is_special_wan_if = ((strcmp(wan_interface, hotspot_wan_ifname) == 0) ||

(strcmp(wan_interface, mesh_wan_ifname) == 0));

if (is_special_wan_if)

{

SetV6Route(lan_if,prev_lan_global_prefix);

}

SetV6Route(lan_if,prefix);

char *token;

Copilot · 2026-01-20T03:00:05Z

source/firewall/firewall_ipv6.c

+        if (strcmp(current_wan_ifname,default_wan_ifname ) == 0)
+        {
+            fprintf(fp, "-A FORWARD ! -s %s -i %s -j LOG_FORWARD_DROP\n", prefix, lan_ifname);
+             fprintf(fp, "-A FORWARD -s %s -i %s -j LOG_FORWARD_DROP\n", prefix, wan6_ifname);
+        }


The conditional check compares current_wan_ifname with default_wan_ifname using strcmp. Both variables are extern and expected to be initialized in firewall.c. However, if either variable is empty (e.g., if sysevent values are not set), strcmp will compare empty strings and return 0 (equal), causing the DROP rules to be applied even when they shouldn't be. Consider adding validation to check that both variables contain non-empty values before the strcmp comparison.

Suggested change

if (strcmp(current_wan_ifname,default_wan_ifname ) == 0)

{

fprintf(fp, "-A FORWARD ! -s %s -i %s -j LOG_FORWARD_DROP\n", prefix, lan_ifname);

fprintf(fp, "-A FORWARD -s %s -i %s -j LOG_FORWARD_DROP\n", prefix, wan6_ifname);

}

if (current_wan_ifname[0] != '\0' &&

default_wan_ifname[0] != '\0' &&

strcmp(current_wan_ifname, default_wan_ifname) == 0)

{

fprintf(fp, "-A FORWARD ! -s %s -i %s -j LOG_FORWARD_DROP\n", prefix, lan_ifname);

fprintf(fp, "-A FORWARD -s %s -i %s -j LOG_FORWARD_DROP\n", prefix, wan6_ifname);

}

Copilot · 2026-01-20T03:00:06Z

source/service_routed/service_routed.c

+	if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+	{
+	    SetV6Route(lan_if,prev_lan_global_prefix);
+	} 
+	SetV6Route(lan_if,prefix);
+	char *token;


Inconsistent indentation: These lines use tabs instead of spaces, which is inconsistent with the surrounding code. The indentation should match the style used elsewhere in the function.

Suggested change

if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

{

SetV6Route(lan_if,prev_lan_global_prefix);

}

SetV6Route(lan_if,prefix);

char *token;

if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

{

SetV6Route(lan_if,prev_lan_global_prefix);

}

SetV6Route(lan_if,prefix);

char *token;

Copilot · 2026-01-20T03:00:06Z

source/service_routed/service_routed.c

 }

 // Function sets the route and assign the ULA address to lan interfaces
+#define PSM_HOTSPOT_WAN_IFNAME "dmsb.wanmanager.if.3.Name"


The macro PSM_HOTSPOT_WAN_IFNAME is defined right before the function routeset_ula. This placement is unusual and makes it easy to miss. Consider moving this macro definition to the top of the file alongside PSM_MESH_WAN_IFNAME (line 174) within the WAN_FAILOVER_SUPPORTED ifdef block, since both macros serve similar purposes and are used together in WAN failover scenarios.

Copilot · 2026-01-20T03:00:06Z

source/service_routed/service_routed.c

+    if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+    {
+	sysevent_get(sr->sefd, sr->setok, "lan_prefix", prev_lan_global_prefix, sizeof(prev_lan_global_prefix));
+    } 


The conditional check on line 2463 and 2490 uses strcmp with wan_interface, hotspot_wan_ifname, and mesh_wan_ifname without verifying these strings are non-empty. If PSM_VALUE_GET_STRING fails or returns empty strings, strcmp could be comparing empty strings. Consider adding checks to ensure these variables contain valid interface names before using them in strcmp operations, or checking for empty strings within the condition.

Suggested change

if ( (strcmp(wan_interface, hotspot_wan_ifname) == 0) || (strcmp(wan_interface, mesh_wan_ifname) == 0))

{

sysevent_get(sr->sefd, sr->setok, "lan_prefix", prev_lan_global_prefix, sizeof(prev_lan_global_prefix));

}

if (wan_interface[0] != '\0' &&

((hotspot_wan_ifname[0] != '\0' && strcmp(wan_interface, hotspot_wan_ifname) == 0) ||

(mesh_wan_ifname[0] != '\0' && strcmp(wan_interface, mesh_wan_ifname) == 0)))

{

sysevent_get(sr->sefd, sr->setok, "lan_prefix", prev_lan_global_prefix, sizeof(prev_lan_global_prefix));

}

rirfha948 added 2 commits January 13, 2026 07:07

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

c605461

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

ef7314c

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

rirfha948 requested review from a team as code owners January 14, 2026 10:16

Copilot AI review requested due to automatic review settings January 14, 2026 10:16

Copilot AI reviewed Jan 14, 2026

View reviewed changes

source/firewall/firewall_ipv6.c Show resolved Hide resolved

rirfha948 requested a review from snayak002c January 14, 2026 14:15

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

30e8353

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

e0fd784

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

Copilot AI review requested due to automatic review settings January 16, 2026 06:45

Copilot started reviewing on behalf of rirfha948 January 16, 2026 06:45 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Update source/service_routed/service_routed.c

f677bf7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 16, 2026 06:57

Copilot started reviewing on behalf of rirfha948 January 16, 2026 06:58 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

7c3d90d

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

ebd28de

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

Copilot AI review requested due to automatic review settings January 16, 2026 10:42

Copilot started reviewing on behalf of rirfha948 January 16, 2026 10:42 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

rirfha948 added 2 commits January 16, 2026 11:00

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

65aa550

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

96bc359

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

Copilot AI review requested due to automatic review settings January 16, 2026 11:41

Copilot started reviewing on behalf of rirfha948 January 16, 2026 11:42 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

rirfha948 added 2 commits January 16, 2026 12:16

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

3545948

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

5166319

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

Copilot AI review requested due to automatic review settings January 16, 2026 14:53

Copilot started reviewing on behalf of rirfha948 January 16, 2026 14:53 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

snayak002c requested changes Jan 16, 2026

View reviewed changes

RDKB-63035: HotSPot - IPv6 connectivity from LAN clients is not working.

26f25a6

Reason for change: Added Firewall rule for LAN traffic Test Procedure: - TBD Risks: None Priority: P3 Signed-off-by: rirfha948 <rasina_irfhan@comcast.com>

snayak002c approved these changes Jan 20, 2026

View reviewed changes

Merge branch 'develop' into topic/RDKB-63035

0fb8c60

Copilot AI review requested due to automatic review settings January 20, 2026 02:55

Copilot started reviewing on behalf of snayak002c January 20, 2026 02:55 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

snayak002c merged commit a25378f into develop Jan 20, 2026
14 of 15 checks passed

github-actions bot locked and limited conversation to collaborators Jan 20, 2026

		DEG_PRINT1("63035 - Line:%d\n", __LINE__);
		sysevent_get(sr->sefd, sr->setok, "lan_prefix", prefix, sizeof(prefix));

-    if ((IsHotspotActive) || (strcmp(wan_interface, mesh_wan_ifname) == 0))
+    if (IsHotspotActive ||
+        (mesh_wan_ifname && mesh_wan_ifname[0] != '\0' &&
+         wan_interface[0] != '\0' &&
+         strcmp(wan_interface, mesh_wan_ifname) == 0))

RDKB 63035 - HotSPot - IPv6 connectivity from LAN clients is not working #174

RDKB 63035 - HotSPot - IPv6 connectivity from LAN clients is not working #174

Uh oh!

Conversation

rirfha948 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

rirfha948 commented Jan 14, 2026 •

edited

Loading