Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates platform default configuration to include new firmware download memory-related syscfg defaults, and adds a small README in cov_docker_script/ pointing to centralized Coverity build system documentation.
Changes:
- Add
FwDwld_AvlMem_RsrvThresholdandFwDwld_ImageProcMemPercentdefaults tosystem_defaults_bci. - Add the same firmware download memory-related defaults to
system_defaults_arm. - Add
cov_docker_script/README.mdthat links to the centralized documentation inrdkcentral/build_tools_workflows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
source/scripts/init/defaults/system_defaults_bci |
Adds two new firmware download-related default settings. |
source/scripts/init/defaults/system_defaults_arm |
Adds two new firmware download-related default settings. |
cov_docker_script/README.md |
Introduces a short redirect README to centralized Coverity build docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,3 @@ | |||
| # 🔧 Coverity Native Build System for RDK-B Components | |||
There was a problem hiding this comment.
The heading includes an emoji, which is inconsistent with the other Markdown docs in this repo (e.g., root README headings). Consider removing the emoji to keep formatting consistent across renderers and documentation tooling.
| @@ -0,0 +1,3 @@ | |||
| # 🔧 Coverity Native Build System for RDK-B Components | |||
|
|
|||
| The documentation and source for the RDK-B native build system has been centralized in [rdkcentral/build_tools_workflows](https://github.com/rdkcentral/build_tools_workflows/blob/develop/cov_docker_script/README.md) No newline at end of file | |||
There was a problem hiding this comment.
This README says the "documentation and source" has been centralized elsewhere, but this directory still contains build-related artifacts (e.g., component_config.json, configure_options.conf). Consider rephrasing to indicate where the canonical documentation lives, without implying the local sources are no longer relevant (or add clarification about deprecation if that's the intent).
| The documentation and source for the RDK-B native build system has been centralized in [rdkcentral/build_tools_workflows](https://github.com/rdkcentral/build_tools_workflows/blob/develop/cov_docker_script/README.md) | |
| The canonical documentation and primary sources for the RDK-B native build system are maintained in [rdkcentral/build_tools_workflows](https://github.com/rdkcentral/build_tools_workflows/blob/develop/cov_docker_script/README.md). This directory still contains build-related configuration and artifacts used by the Coverity workflow; refer to the upstream repository for the most up-to-date usage and design details. |
| #FwDwld_AvlMem_RsrvThreshold Default value | ||
| $FwDwld_AvlMem_RsrvThreshold=20 | ||
|
|
||
| #FwDwld_ImageProcMemPercent Default value | ||
| $FwDwld_ImageProcMemPercent=0 |
There was a problem hiding this comment.
The PR metadata/title indicates this is a "Rebase", but the diff introduces new syscfg defaults and adds new documentation. Please update the PR title and/or description to reflect the functional changes so reviewers/releasers can understand impact.
NareshM1702
force-pushed
the
topic/RDKB-63406
branch
from
8964ae6 to
9591b2c
Compare
NareshM1702
force-pushed
the
topic/RDKB-63406
branch
from
9591b2c to
e941e3b
Compare
No description provided.