RDKB-63135, RDKB-63664 : Handle Security Edge feature for business#241
RDKB-63135, RDKB-63664 : Handle Security Edge feature for business#241
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for two new XB10 device models (CGM601TCOM and SG417DBCT) to enable the Security Edge XDNS/DNSSec feature. According to the PR description, these features should only work in business device mode, but the implementation only adds box type checks without any device mode validation.
Changes:
- Added CGM601TCOM and SG417DBCT to the list of supported models for XDNS DNSSec functionality in both C and shell script implementations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| source/service_dhcp/service_dhcp_server.c | Adds CGM601TCOM and SG417DBCT to box type conditional for enabling DNSSec proxy feature in dnsmasq server start |
| source/scripts/init/service.d/service_dhcp_server.sh | Adds CGM601TCOM and SG417DBCT to model number conditional for enabling DNSSec proxy feature in shell script dnsmasq startup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Handle Security Edge feature for business
Test Procedure:
Functionality of the following DMLs need to be tested:
Above mentioned DML parameters SHOULD work only if the devicemode is business.
Risks: Low
Priority: P1
Signed-off-by: Santhosh_GujulvaJagadeesh@comcast.com