RDKB-63711 Enable the WanPingEnable option for OneStack#249
Merged
anoopchelakkode merged 1 commit intodevelopfrom Feb 27, 2026
Merged
RDKB-63711 Enable the WanPingEnable option for OneStack#249anoopchelakkode merged 1 commit intodevelopfrom
anoopchelakkode merged 1 commit intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the existing WAN ping disable rule paths to also compile and apply for OneStack builds, unblocking use of the WanPingEnable / WanPingEnableV6 configuration on OneStack products.
Changes:
- Extend IPv6 WAN ping disable handling to build for
_ONESTACK_PRODUCT_REQ_in addition to_COSA_FOR_BCI_. - Extend IPv4 WAN ping disable handling to build for
_ONESTACK_PRODUCT_REQ_in addition to_COSA_FOR_BCI_.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
source/firewall/firewall_ipv6.c |
Expands the compile-time guard so OneStack builds include the IPv6 WAN ping disable rules that were previously BCI-only. |
source/firewall/firewall.c |
Expands the compile-time guard so OneStack builds include the IPv4 WAN ping disable rules that were previously BCI-only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hpatel006c
approved these changes
Feb 27, 2026
anoopchelakkode
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
US: RDKB-63097: Subtask: RDKB-63711 Enable the WanPingEnable option for OneStack
Reason for change: Add changes to ensure that code is unblocked in OneStack case for WanPingEnable option.
Test Procedure: Build with OneStack distro and test
Risks: None
Is this a Bug or a User Story (US)?: US: RDKB-63097 [XB10] Handle static IPv4 configuration for business Partner ID. Subtask: RDKB-63711
If it is a User Story:
• Gerrit topic or list of all dependent PRs across components (including meta-layer changes) been shared?:
rdkcentral/provisioning-and-management#229