Skip to content

CBR2-2262 : set primary_lan_l3net sysevent#302

Open
rajkamal-cv wants to merge 3 commits into
developfrom
bug/CBR2-2262
Open

CBR2-2262 : set primary_lan_l3net sysevent#302
rajkamal-cv wants to merge 3 commits into
developfrom
bug/CBR2-2262

Conversation

@rajkamal-cv
Copy link
Copy Markdown
Contributor

Reason for change: Fix the typo in setting primary_lan_l3net sysevent
Test Procedure: Flash the image and test the brlan0 in CBR2
Risks: Low
Priority: P1

Reason for change: Fix the typo in setting primary_lan_l3net sysevent
Test Procedure: Flash the image and test the brlan0 in CBR2
Risks: Low
Priority: P1
Copilot AI review requested due to automatic review settings May 7, 2026 03:00
@rajkamal-cv rajkamal-cv requested review from a team as code owners May 7, 2026 03:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a typo in the LAN initialization handler intended to ensure the primary_lan_l3net sysevent is set correctly for CBR2/TCCBR scenarios.

Changes:

  • Replace an invalid syseven invocation with sysevent set primary_lan_l3net 4.
  • Replace a no-op echo (redirected to /dev/null) with an echo_t log message in the same branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 439 to 443
elif [ "$BOX_TYPE" = "TCCBR" ]; then
if [ -z "$INST" ]; then
echo "*****SET THE PRIMARY LAN ******" > /dev/null
syseven set primary_lan_l3net 4
echo_t "SET THE PRIMARY LAN $INST"
sysevent set primary_lan_l3net 4
fi
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit e0301c9. I moved the TCCBR fallback out of the if [ x != x$INST ] block so it now executes correctly when INST is empty, and still defaults primary_lan_l3net to 4 for that case.

Comment thread source/scripts/init/service.d/lan_handler.sh Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 01:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Agent-Logs-Url: https://github.com/rdkcentral/utopia/sessions/fcfd6e0e-8b1c-4360-b167-6809a7b5b990

Co-authored-by: rajkamal-cv <72071311+rajkamal-cv@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented May 19, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • git.netfilter.org
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED cp umbe�� gpack bash ndor/bin/cp /include/rdkb (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants