RDKB-60436 : Cold Standby Support in WAN Manager for WiFi Hotspot Failover.#172
Merged
Conversation
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 3, 2025 10:34
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements Cold Standby Support in WAN Manager for WiFi Hotspot Failover, addressing status mismatch issues during physical interface down/up transitions.
Key changes:
- Refactored interface initialization logic into a new reusable function
WanManager_InitializeInterfaceInfo - Enhanced DHCP cleanup to include MAP-T and DSLite status clearing
- Added proper state management in
wan_transition_wan_deconfiguredto handle interface deactivation scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 3, 2025 10:39
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 3, 2025 17:04
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
S-Parthiban-Selvaraj
previously approved these changes
Dec 4, 2025
…lover. Reason for change: RDKB-59763 - Develop that US acceptance criteria. Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed. Test Procedure: Build should passed WANManager functionality should work without any issue Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 4, 2025 18:21
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guto86
approved these changes
Dec 4, 2025
S-Parthiban-Selvaraj
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
RDKB-59763 - Develop that US acceptance criteria.
Status mismatch happening during Phy Down and Up for Interface so that needs to be addressed.
Test Procedure:
Build should passed
WANManager functionality should work without any issue
Risks: Medium
Signed-off-by: LakshminarayananShenbagaraj lakshminarayanan.shenbagaraj2@sky.uk