RDKB-62747 : HS - IPv6 address is not removed after RBUS API WAN Stop.#175
Merged
Conversation
Looks like during IPv6 tear down we were resetting the virtual interface status to Down due to the reason IPv6 and route were not cleared. https://github.com/rdkcentral/wan-manager/blob/main/source/WanManager/wanmgr_interface_sm.c#L2656 Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 10, 2025 14:27
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where IPv6 addresses and routes were not being properly removed during WAN stop operations. The fix moves the interface status update to occur after IPv6 teardown completes, ensuring cleanup operations execute successfully before marking the interface as down.
- Relocates
WanManager_UpdateInterfaceStatus()call to execute after IPv6 teardown operations - Aligns IPv6 down flow with IPv4 down flow pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 11, 2025 10:29
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 11, 2025 12:36
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 15, 2025 11:12
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Looks like during IPv6 tear down we were resetting the virtual interface status to Down due to the reason IPv6 and route were not cleared. https://github.com/rdkcentral/wan-manager/blob/main/source/WanManager/wanmgr_interface_sm.c#L2656 Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Looks like during IPv6 tear down we were resetting the virtual interface status to Down due to the reason IPv6 and route were not cleared. https://github.com/rdkcentral/wan-manager/blob/main/source/WanManager/wanmgr_interface_sm.c#L2656 Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Looks like during IPv6 tear down we were resetting the virtual interface status to Down due to the reason IPv6 and route were not cleared. https://github.com/rdkcentral/wan-manager/blob/main/source/WanManager/wanmgr_interface_sm.c#L2656 Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Looks like during IPv6 tear down we were resetting the virtual interface status to Down due to the reason IPv6 and route were not cleared. https://github.com/rdkcentral/wan-manager/blob/main/source/WanManager/wanmgr_interface_sm.c#L2656 Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 15, 2025 16:23
View session
S-Parthiban-Selvaraj
approved these changes
Dec 16, 2025
guto86
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR fixes an issue where IPv6 addresses and routes were not being properly removed during WAN stop operations. The fix moves the interface status update to occur after IPv6 teardown completes, ensuring cleanup operations execute successfully before marking the interface as down.
WanManager_UpdateInterfaceStatus()call to execute after IPv6 teardown operations💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.