RDKB-62572 : [SKY-VL-QE][Sprint]: LED status is not changing on WAN cable disconnect.#178
Merged
Merged
Conversation
…able disconnect. Reason for change: This issue is a regression due to RDKB-59763 US changes. Where interface state machine used to start after physical status Up event only but now we have changed the flow where interface state machine starts before Phy up and wait for Up. So LED status behavior also changed accordingly so corrected this behavior now. Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 20, 2025 23:43
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in LED status behavior introduced by RDKB-59763, where the LED status was not updating correctly when a WAN cable is disconnected. The root cause was a change in the interface state machine (ISM) flow, which now starts before the physical link is UP, affecting the LED update logic.
Key Changes:
- Restructured the LED status update logic to prioritize physical link status checks before state machine status
- Added separate handling for when PHY is UP vs DOWN, with appropriate LED state updates for each scenario
- Updated the order of state tracking to reflect PHY state changes first, then state machine state changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
S-Parthiban-Selvaraj
previously approved these changes
Dec 22, 2025
…able disconnect. Reason for change: This issue is a regression due to RDKB-59763 US changes. Where interface state machine used to start after physical status Up event only but now we have changed the flow where interface state machine starts before Phy up and wait for Up. So LED status behavior also changed accordingly so corrected this behavior now. Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
…able disconnect. Reason for change: This issue is a regression due to RDKB-59763 US changes. Where interface state machine used to start after physical status Up event only but now we have changed the flow where interface state machine starts before Phy up and wait for Up. So LED status behavior also changed accordingly so corrected this behavior now. Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 22, 2025 15:27
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 22, 2025 16:01
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
S-Parthiban-Selvaraj
approved these changes
Dec 23, 2025
guto86
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR fixes a regression in LED status behavior introduced by RDKB-59763, where the LED status was not updating correctly when a WAN cable is disconnected. The root cause was a change in the interface state machine (ISM) flow, which now starts before the physical link is UP, affecting the LED update logic.
Key Changes:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.