RDKEMW-16005-4: Resolve Low priority coverity issues#32
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses low-priority Coverity findings in the Westeros compositor by cleaning up variadic logging macros (PRINTF_ARGS-related) and removing parameter-hiding locals (PW.PARAMETER_HIDDEN-related) to improve static-analysis correctness without changing runtime behavior.
Changes:
- Update logging macros to use comma-swallowing variadic forwarding (avoids passing dummy arguments that can break printf-format checking).
- Rename several local variables to avoid shadowing function parameters (improves clarity and satisfies Coverity checks).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trupthi1403
force-pushed
the
topic/RDKEMW-16005-4
branch
from
72ad557 to
86fd131
Compare
Contributor
|
Changes look good to merge. |
sajnanazeer
approved these changes
Jun 2, 2026
Reason for change: Changes to fix PRINTF_ARGS and PW.PARAMETER_HIDDEN coverity issues Test Procedure: Refer Ticket Risks: Low Priority: P2
trupthi1403
force-pushed
the
topic/RDKEMW-16005-4
branch
from
86fd131 to
e76df2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Changes to fix PRINTF_ARGS and PW.PARAMETER_HIDDEN coverity issues
Test Procedure: Refer Ticket
Risks: Low
Priority: P2