Skip to content

style: apply readability-braces-around-statements#8136

Merged
greglandrum merged 1 commit intordkit:masterfrom
e-kwsm:readability-braces-around-statements
Feb 9, 2026
Merged

style: apply readability-braces-around-statements#8136
greglandrum merged 1 commit intordkit:masterfrom
e-kwsm:readability-braces-around-statements

Conversation

@e-kwsm
Copy link
Copy Markdown
Contributor

@e-kwsm e-kwsm commented Dec 24, 2024

Reference Issue

What does this implement/fix? Explain your changes.

rdkit/.clang-tidy

Line 2 in bebd2eb

Checks: '-*,boost-use-to-string,modernize-use-auto,modernize-use-nullptr,modernize-loop-convert,modernize-use-override,modernize-pass-by-value,modernize-shrink-to-fit,readability-braces-around-statements,readability-simplify-boolean-expr'

Any other comments?

@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 68f72fc to e328c57 Compare January 1, 2025 03:39
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 335f6d7 to 94c1368 Compare January 9, 2025 07:37
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 3 times, most recently from f47276d to 42807c9 Compare January 19, 2025 21:11
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 3ea80d3 to a8c96ac Compare January 31, 2025 09:15
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 108c2f6 to 5db99c0 Compare February 26, 2025 16:54
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 3c48dea to cb9df2b Compare March 8, 2025 04:44
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 67eb65e to 1760af2 Compare March 20, 2025 15:04
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 3 times, most recently from f4f91fa to 341db60 Compare April 1, 2025 06:24
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 341db60 to 1176f78 Compare April 2, 2025 04:53
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 1176f78 to 2aec4a3 Compare April 9, 2025 12:05
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 2aec4a3 to f79583b Compare April 17, 2025 01:20
greglandrum
greglandrum requested changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some files in here that shouldn't be, but everything else looks good.

Please remove the .cmake files

Comment thread Code/GraphMol/SLNParse/lex.yysln.cpp.cmake
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from f79583b to 1ae61cd Compare May 2, 2025 14:58
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from b9c1d52 to bb67895 Compare May 14, 2025 13:56
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 2947f00 to a1cd729 Compare May 24, 2025 12:14
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 1ebe265 to 745d7fd Compare June 1, 2025 23:37
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 745d7fd to d1a07d4 Compare June 6, 2025 19:45
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 38980fc to f80ae0c Compare August 1, 2025 16:40
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 4c39e87 to 2d41b4d Compare September 3, 2025 17:15
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 50be71f to 9296766 Compare September 27, 2025 08:41
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 9296766 to a1665fe Compare October 2, 2025 11:38
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from a1665fe to 1265ee6 Compare October 10, 2025 22:32
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 1265ee6 to 0c5f011 Compare October 18, 2025 09:43
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from b5588d1 to 804d41f Compare October 30, 2025 19:55
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 804d41f to aa405e5 Compare November 11, 2025 22:27
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 59c6afa to aabd100 Compare December 3, 2025 11:31
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 1d42672 to 05bf33d Compare December 16, 2025 04:05
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from 17d3b94 to e8a25a5 Compare December 30, 2025 11:06
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch 2 times, most recently from d696602 to 0f7e201 Compare January 12, 2026 18:18
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 0f7e201 to 68ef6f1 Compare January 23, 2026 07:18
@e-kwsm e-kwsm force-pushed the readability-braces-around-statements branch from 68ef6f1 to d6dc1f2 Compare February 7, 2026 06:33
greglandrum
greglandrum approved these changes Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greglandrum
Copy link
Copy Markdown
Member

greglandrum commented Feb 9, 2026

will merge after the CI builds finish

@greglandrum greglandrum merged commit e89c9f6 into rdkit:master Feb 9, 2026
12 checks passed
@greglandrum
Copy link
Copy Markdown
Member

greglandrum commented Feb 9, 2026

Thanks @e-kwsm!

@greglandrum greglandrum added the Cleanup Code cleanup and refactoring label Feb 9, 2026
@greglandrum greglandrum added this to the 2025_09_6 milestone Feb 9, 2026
@e-kwsm e-kwsm deleted the readability-braces-around-statements branch February 9, 2026 18:28
greglandrum pushed a commit that referenced this pull request Feb 27, 2026
@e-kwsm @greglandrum
style: apply readability-braces-around-statements (#8136)
112bb25 
Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greglandrum greglandrum greglandrum approved these changes

Assignees

No one assigned

Labels

Cleanup Code cleanup and refactoring

Projects

None yet

Milestone

2025_09_6

Development

Successfully merging this pull request may close these issues.

2 participants

@e-kwsm @greglandrum