Fix potential iterator invalidation#8944
Merged
greglandrum merged 1 commit intordkit:masterfrom Nov 11, 2025
Merged
Conversation
The iterator in the loop over bonds (changed in utils.cpp) is potentially invalidated by adding bonds to the molecule. We copy the bonds into a vector to ensure safety.
Member
|
@rietmann-nv thanks for the contribution! |
greglandrum
pushed a commit
that referenced
this pull request
Nov 28, 2025
The iterator in the loop over bonds (changed in utils.cpp) is potentially invalidated by adding bonds to the molecule. We copy the bonds into a vector to ensure safety.
pechersky
pushed a commit
to pechersky/rdkit
that referenced
this pull request
Jan 7, 2026
The iterator in the loop over bonds (changed in utils.cpp) is potentially invalidated by adding bonds to the molecule. We copy the bonds into a vector to ensure safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iterator in the loop over bonds (changed in utils.cpp) is potentially invalidated by adding bonds to the molecule. We copy the bonds into a vector to ensure safety.
What does this implement/fix? Explain your changes.
We found an iterator invalidation when re-writing the backend and decided to port this over to the existing codebase in anticipation of future merges.