Modernize loops and clean up ring finding#9098
Merged
greglandrum merged 5 commits intordkit:masterfrom Feb 11, 2026
Merged
Conversation
greglandrum
requested changes
Feb 10, 2026
Member
greglandrum
left a comment
greglandrum
left a comment
There was a problem hiding this comment.
a couple of small suggestions
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
ricrogz
added a commit
to ricrogz/rdkit
that referenced
this pull request
Feb 10, 2026
greglandrum
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functionality change intended here, just cleaning up ahead of some work on ring finding towards #9064 and some canonicalization issues.
I'll do more cleaning up and refactoring in coming PRs.