Copy project from detail information page#1612
Conversation
|
Coverage is 94.091% — 3.0.0/project/copy into 3.0.0/release. No base build found for |
| import CopyProjectModal from '../../../../common/components/CopyProjectModal' | ||
|
|
||
| const CopyProjectButton = ({ project }) => { | ||
| const [selectedProject, setSelectedProject] = useState(null) |
There was a problem hiding this comment.
I don't think this state is needed, there is only one project in the dashboard and nothing to select.
| </div> | ||
| </form > | ||
|
|
||
| { |
There was a problem hiding this comment.
I think this should be on a seperate card in the Information component, above "delete project".
There was a problem hiding this comment.
As discussed and decided today we add a link styled button next to the headline of this page; move it away from inside the ProjectForm
|
|
||
| import CopyProjectModal from '../../../../common/components/CopyProjectModal' | ||
|
|
||
| const CopyProjectButton = ({ project }) => { |
There was a problem hiding this comment.
I think CopyProject would be a better name, it would match more with the other components. It's contains a bit more than a button.
There was a problem hiding this comment.
Most of the changes in this file are formatting, right?
There was a problem hiding this comment.
As I added the button I had to add also a react fragment, so all code was indented additionally. Try watch this with "Hide whitespace" setting enabled and you'll see the real changes.
There was a problem hiding this comment.
I removed that button anyway, so should be no issue at all in this PR anymore
CalamityC
force-pushed
the
3.0.0/project/copy
branch
from
dbf0603 to
19c4811
Compare
CalamityC
force-pushed
the
3.0.0/project/copy
branch
from
c0049eb to
b6b34ec
Compare
3 participants
No description provided.