Add original option to RulesEngine::Set #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louman
approved these changes
Mar 15, 2019
| @@ -1,8 +1,11 @@ | |||
| class RulesEngine::Set | |||
| attr_reader :root, :name | |||
| attr_reader :name, | |||
There was a problem hiding this comment.
Any reason for indenting down? It's not like we're developing using phone screens :P
There was a problem hiding this comment.
But seriously, I changed it to match the format of RulesEngine::Outcome and RulesEngine::Condition plus I usually switch to a vertical format when the list gets to be 3 or 4 in length so that it makes it easier to scan the list for attributes. Being a converted trailing comma enthusiast, I'd love to hang a comma off the last item in the list but sadly I can't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to access the original rule set in the same way as with condition and outcome.