Skip to content

Kepler plugin calculate emissions#127

Merged
gabibeyer merged 1 commit intomainfrom
kepler_hack
May 21, 2024
Merged

Kepler plugin calculate emissions#127
gabibeyer merged 1 commit intomainfrom
kepler_hack

Conversation

@gabibeyer
Copy link
Copy Markdown
Contributor

No description provided.

@gabibeyer gabibeyer requested a review from Spazzy757 May 20, 2024 16:33
@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2024

Deploy Preview for aether-docs canceled.

Name Link
🔨 Latest commit 5dd7502
🔍 Latest deploy log https://app.netlify.com/sites/aether-docs/deploys/664c8c07eb875500088a0eac

Comment thread charts/aether/values.yaml Outdated
Comment thread charts/aether/templates/deployment.yaml Outdated
@gabibeyer gabibeyer requested a review from Spazzy757 May 21, 2024 10:40
@gabibeyer gabibeyer force-pushed the kepler_hack branch 2 times, most recently from 4678feb to 7c917fc Compare May 21, 2024 10:43
Spazzy757
Spazzy757 previously approved these changes May 21, 2024
Copy link
Copy Markdown
Contributor

@Spazzy757 Spazzy757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pkg/calculator/handler.go Outdated
Since kepler already calculates energy consumption, only
emissions are necessary for reporting. For now, add a logic hack
until the code decouples energy and carbon calculations.
@gabibeyer gabibeyer merged commit cf270b3 into main May 21, 2024
@gabibeyer gabibeyer deleted the kepler_hack branch May 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants