refactor(health): extract internal/health; webui drops tui import (#1497 partial 3.3)#1519
Merged
Merged
Conversation
- New internal/health package owns CheckStatus, CheckResult, DataProvider interface, and DefaultDataProvider with all 9 built-in checks. Status enum: StatusOK/Warn/Err/Checking. - internal/webui/handlers_health.go imports internal/health instead of internal/tui. Cross-presentation coupling removed. - internal/tui/health_provider.go is now a thin shim of type aliases (HealthCheckStatus, HealthCheckResultMsg, HealthDataProvider, DefaultHealthDataProvider) and a NewDefaultHealthDataProvider constructor that delegates to the health package. All existing TUI consumers (health_list.go, health_detail.go, content_health.go, app.go, tests) keep their identifiers unchanged via aliasing. - Verified: go list -deps internal/webui no longer contains internal/tui. Partial of #1497 (subset 3.3).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/healthpackage ownsCheckStatus,DataProvider,DefaultDataProvider, status enum, check helpersinternal/webui/handlers_health.goimportsinternal/healthinstead ofinternal/tuiinternal/tui/health_provider.goreduced to 36 LOC alias shim — preserves type identity fortui.HealthCheckResultMsg == health.CheckResultso bubbletea message dispatch unaffectedDirection reversed (verified)
Symbols moved
HealthCheckStatushealth.CheckStatusHealthCheckOK/Warn/Err/Checkinghealth.StatusOK/Warn/Err/CheckingHealthCheckResultMsghealth.CheckResultHealthDataProviderhealth.DataProviderDefaultHealthDataProviderhealth.DefaultDataProviderNewDefaultHealthDataProviderhealth.NewDefaultDataProvidercheck*methods*DefaultDataProviderValidation
go build ./...+go vet ./...cleango test -race ./internal/health/...okgo test -race ./internal/tui/...ok (5.2s)go test -race ./internal/webui/...ok (79.9s; includesTestHealthStatusString,TestHandleAPIHealth,TestHandleHealthPage)Out of scope (deferred)
health_provider.go569→36 LOC delete shim once tui consumers migrate fully — separate ticketTest plan
wave serve/health endpoint renderswave tuihealth panel unchanged from user perspectivePartial of #1497 (subset 3.3). Parent: #1494.