refactor(onboarding): wave init delegates to BaselineService (1.3)#1588
Merged
Conversation
Wire cmd/wave init to onboarding.BaselineService.StartSession instead of the legacy RunWizard machinery. Delete the wizard step types (WizardConfig, WizardResult, WizardStep, DependencyStep, TestConfigStep, PipelineSelectionStep, AdapterConfigStep, ModelSelectionStep, SkillSelectionStep, WaveCommandStep), the PrepareWizard / WizardOpts / WizardWaveDirs helpers, and PrintWizardSuccess. Update validate_test.go to drive BaselineService for its onboarding fixture. Interactive prompts are deliberately removed pending the follow-up UI work in the parent epic — non-interactive --yes / --reconfigure / --merge behaviour remains intact. Refs #1578, epic #1565.
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd/wave/commands/init.goto delegate throughBaselineService(PRE-2) instead of the legacyRunWizardpathonboarding.go,steps.go,flow.go,output.go,scaffold.go,skill_step.go,wave_command_step.goand their testsflavour.go+metadata.go(still used for detection)validate_test.goto match new init wiringRelated to #1578
Changes
cmd/wave/commands/init.go— wizard path replaced byBaselineServicecall (193→shrunk to delegation)internal/onboarding/onboarding.go,steps.go,flow.go,output.go,scaffold.go,skill_step.go,wave_command_step.go— deleted (~2200 lines of legacy wizard machinery)internal/onboarding/{onboarding,steps,skill_step,wave_command_step}_test.go— deleted (legacy tests)cmd/wave/commands/validate_test.go— adapted for new init signaturespecs/1578-init-onboarding-service/{spec,plan,tasks}.md— planning artifactsTest Plan
go build ./...passesgo test ./...passeswave initnon-interactive smoke run on greenfield repowave init --interactiveroutes through service