feat(webui,cli): proposals approval UI for evolution gate#1614
Merged
Conversation
3 tasks
Add human-approval gate for evolution proposals via webui /proposals (list/detail/approve/reject) and CLI `wave proposals` (list/show/approve/ reject). Approve calls EvolutionStore.DecideProposal then CreatePipelineVersion(active=true) using sha256 of post-diff yaml; reject only marks the proposal decided. Diff render uses escaped <pre> with class spans, no new chroma dep. Webui reuses per-session CSRF middleware.
nextlevelshit
force-pushed
the
1613-proposals-approval-ui
branch
from
ea80856 to
14f067e
Compare
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proposalswebui (list + detail with diff render, approve/reject POST routes)wave proposals list|show|approve|rejectCLI subcommandinternal/proposals/approve.goto atomically flippipeline_version.activeon approvalRelated to #1613
Changes
internal/webui/handlers_proposals.go(+341),routes.go,embed.go— webui handlers + route mountinternal/webui/templates/proposals/{list,detail}.html+layout.html— UI templatescmd/wave/commands/proposals.go(+319) +main.go— CLI subcommandinternal/proposals/approve.go(+110) — DecideProposal + active version flipspecs/1613-proposals-approval-ui/{spec,plan,tasks}.md— planning docshandlers_proposals_test.go(+266),proposals_test.go(+267)Test Plan
go test ./internal/webui/... ./cmd/wave/commands/... ./internal/proposals/...pipeline_versionactive flips →wave run <pipeline>uses new version