feat(webui): migrate /analytics, /retros, /skills, /compose to unified design system#1641
Merged
Merged
Conversation
…d design system Convert analytics, retros, skills, and compose pages from layout-based templates to standalone templates with w-* design system classes. Analytics and retros retain their existing analytics-*/retro-* CSS classes. Skills and compose use the unified design system. Part of #1624 (WebUI UX consolidation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/analytics,/retros,/skills,/composepages from layout-based to standalone templates with unifiedw-*design system classesanalytics-*/retro-*CSS classes (already in style.css)wr-*tow-*design system classesstandalonePageTemplatesinembed.goExecute()instead ofExecuteTemplate()Preserves all functionality: bar charts, rank lists, install buttons, compose dialog with advanced options.
Standalone pages after this PR: 18 total (work/board, work/detail, onboard, proposals/list, proposals/detail, runs, pipelines, issues, prs, health, contracts, personas, notfound, analytics, retros, skills, compose)
Remaining layout-based pages: run_detail, pipeline_detail, issue_detail, pr_detail, persona_detail, contract_detail, skill_detail, webhook_detail, compare, webhooks, admin (11 — mostly detail pages + admin/compare/webhooks which are complex)
Part of #1624 (WebUI UX consolidation).
Test plan
go test ./internal/webui/passes/analyticsrenders stat cards, bar chart, rank lists/retrosrenders smoothness chart, friction table, pipeline rates/skillsrenders installed/available/required sections, install buttons work/composerenders pipeline list, start dialog with advanced options