fix(webui): increase /issues page timeout from 15s to 30s#696
Open
nextlevelshit wants to merge 2 commits intomainfrom
Open
fix(webui): increase /issues page timeout from 15s to 30s#696nextlevelshit wants to merge 2 commits intomainfrom
nextlevelshit wants to merge 2 commits intomainfrom
Conversation
Collaborator
Author
Code Review (Wave Pipeline)Verdict: COMMENT PR #696 correctly fixes the Major Findings
Minor Findings
Suggestions
Generated by Wave ops-pr-review pipeline |
Add dedicated ForgeAPIList timeout constant (30s) for forge list operations that need more headroom than single-item fetches (15s). The /issues page was timing out on repos with 600+ issues because the shared context across retries with exponential backoff exceeded the 15-second deadline.
174febf to
03d85a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/issuespage was timing out withcontext deadline exceededon repos with 600+ issuesIssuesPageTimeoutconstant to the timeouts packagehandlers_issues.goto use the new 30s timeout instead of the generic 15sPageTimeoutRelated to #689
Changes
internal/timeouts/timeouts.go— addedIssuesPageTimeout = 30 * time.Secondconstantinternal/webui/handlers_issues.go— switched fromtimeouts.PageTimeouttotimeouts.IssuesPageTimeoutinternal/webui/handlers_issues_test.go— new test validating timeout behaviorspecs/689-issues-timeout/— spec, plan, and task documentationTest Plan
TestHandleIssuesTimeoutto verify the handler uses the correct 30s timeoutgo test ./...