Add back functionality to navigate route#197
Conversation
|
Any chances this gets merged ? I think this is pretty useful for Gatsby as the Related to this issue. |
|
Any update for this PR? |
|
Would love to see this get merged. 🤘 |
|
Does this implementation re-render the previous tree? #44 (comment) |
|
This would be great! |
|
+1 |
|
Why not merge this commit? |
|
+1000000 |
|
Please refrain from adding +1 comments. Adding emoji reacts communicates the same enthusiasm for the work without cluttering the thread |
|
+1 |
|
+100 |
|
+1000 |
|
I believe that the |
|
+10000 |
|
Coming from Gatsby as well, wondering why it's still not possible to simply So, what's missing for this PR to get merged? Feedback from @ryanflorence ? Clicking "merge" by @stasiukanya? |
|
Thanks for your patience. My hesitation here has been around how suspense and caches are going to work. If you click "back" do we need to go into the This PR assumes the cache will be filled. And I suppose the code already assumes they will be filled if the user clicks back. Anyway, we may find issues when suspense ships in 2032, and we can figure out what to do then. (j/k react team I love you suspense is going to be amazing) |
|
Should this now be working as its merged to master? I'm using v1.2.1 and passing an int to navigate just attaches it to the end of the url |
|
I'm having the same issue. navigate(-1) just appends '-1' to the end of the url |
|
When this works I have some production workarounds to rectify xD |
|
|
|
I'm also on 1.2.1 and it is just appending a -1. |
|
Yeah so the fix is on the beta release, so just do ‘yarn add @reach/router@next’ |
|
In some use cases I suggest:
|
|
I am also seeing the issue where navigate(-1) is appending a -1 to the url. I ran ‘yarn add @reach/router@next’ as suggested by @rickiesmooth but the issues persists. Any fix for this yet? This is my implementation in Gatsby |
FYI I fixed this by updating my project's packages to the latest versions by running I'm assuming this worked because I got the latest fix to gatsby mentioned above (gatsby was updated to v2.24.63) |
Implements #44
Uses
history.goas suggested by @ryanflorence in #44 (comment)