setState not re rendering in version ^1.0.0

[dpram17]

Hi @AllenFang

I have a function which simply sets the state of a variable, based on the row index. Version 1.0.0 works perfectly with the code. But when I installed the new version ^1.0.0, it somehow stops rendering. It sets the state of the variable, but doesn't re render. I will provide some code snippets to back this issue.

Note : Basically the column formatter method is not getting called. (No error in console)

Thanks
The div that has a onClick handler:

       <div
        role="button"
        tabIndex="0"
        onKeyDown={() => this.handleSettings(rowIndex)}
        className={gearIconWrapper ${showGearOptions}}
        onClick={() => this.handleSettings(rowIndex)}
      >

The function that's setting the state, but not re rendering :

this.handleSettings = this.handleSettings.bind(this);
handleSettings(rowIndex) { this.setState({ activeIndex: rowIndex, }); }

[AllenFang]

@dpramani firstly could you please make sure what version u used now?

secondly, please show me the code of column.formatter. In addition, please check this and be carefully on "Attention" part. Because after 1.1.0 we improve the performance of cell level rendering.

[waynebrantley]

I can confirm this.
https://codesandbox.io/s/4zkpv0n4ww

In this example, click the button and you will see that only the 3rd column will re-render.
However, if I make the datafield="inStock" for the last column and blank for 3rd column - then the 4th column will re-render, but not the 3rd column.

Only the column named 'instock' will be updated. I cannot name them both instock as an error will occur. Additionally, the logic in the formatter could rely on several fields

[AllenFang]

@waynebrantley this is probably special case, I will look into your case. Thank you for providing this issue.

[waynebrantley]

@AllenFang thanks for fixing. Of note - if there are several dummy or calculated columns, we have to make up 'fake field names' as you require the field names to be unique. So only one "" column is allowed.

Additionally, you could add an optional 'shouldCellUpdate' for a column - you could pass current and next row into it...we could return true/false based on whatever logic - thereby optimizing the rendering.

[AllenFang]

@waynebrantley

if there are several dummy or calculated columns, we have to make up 'fake field names' as you require the field names to be unique. So only one "" column is allowed.

yes, in the patch, dataField can be anything, but just keep it unique when u assign the isDummyField as true

Additionally, you could add an optional 'shouldCellUpdate' for a column - you could pass current and next row into it...we could return true/false based on whatever logic

That could be a good idea. Currently, we have some optimizing on cell level component, that's already enough. But I think I have to think about the timing for using shouldCellUpdate option. Anyway, it's good idea.

BTW, this issue will be fixed later. Wait my signal, thank you

[AllenFang]

@waynebrantley

RELEASE NOTE

YOUR EXAMPLE .

Please upgrade related packages to newest version, thanks

[waynebrantley]

@AllenFang Thanks!