Set custom class or style for disabled/non-selectable. [Improve #1135] #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenFang
reviewed
Nov 9, 2019
| { | ||
| "name": "react-bootstrap-table2-editor", | ||
| "version": "1.3.2", | ||
| "version": "1.4.0", |
There was a problem hiding this comment.
Don't bump the version, I bump the version though lerna when I released, please revert this change.
AllenFang
reviewed
Nov 9, 2019
| { | ||
| "name": "react-bootstrap-table2-filter", | ||
| "version": "1.1.12", | ||
| "version": "1.2.0", |
There was a problem hiding this comment.
same here, don't bump the version
AllenFang
reviewed
Nov 9, 2019
| { | ||
| "name": "react-bootstrap-table2-paginator", | ||
| "version": "2.0.8", | ||
| "version": "2.1.0", |
There was a problem hiding this comment.
same here, don't bump the version
AllenFang
reviewed
Nov 9, 2019
| { | ||
| "name": "react-bootstrap-table2-toolkit", | ||
| "version": "2.0.1", | ||
| "version": "2.1.0", |
There was a problem hiding this comment.
same here, don't bump the version
AllenFang
reviewed
Nov 9, 2019
| { | ||
| "name": "react-bootstrap-table-next", | ||
| "version": "3.1.9", | ||
| "version": "3.2.1", |
There was a problem hiding this comment.
same here, don't bump the version
|
HI @Ymbere thanks for your contributions, it's a great start for you. Overall for me the implementation is good but I have some comments, please fix it then I will merge your code. Thanks BTW, please also rebase you code |
Add new props to the bootstrap-table, nonSelectableStyle and nonSelectableClasses Update row-consume in order to support custom styles and classes for non selectable rows
Add `nonSelectableStyle` documentation Add `nonSelectableClasses` documentation
|
HI @Ymbere I appreciate your hard work, it's awesome, thank a million lots~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve #1135
Improves the solution provided on issue # 1135, instead of using a workaround its possible to provide the
nonSelectableStyleandnonSelectableClassesdirectlyStyle
Class