Skip to content

Conversation

jehartzog
Copy link
Contributor

You swapped value and label in the fix for #641.

This corrects that swap.

You will also want to update your docs as it currently uses a swapped example:

const selectOptions = [
  { label: 0, value: 'good' },
  { label: 1, value: 'Bad' },
  { label: 2, value: 'unknown' }
];

@jehartzog
Copy link
Contributor Author

@AllenFang Tagging you as requested. Thanks for getting the updates into a new release so quickly :D.

@AllenFang
Copy link
Member

ok, I will handle this, thanks

@AllenFang AllenFang changed the base branch from master to develop November 10, 2018 07:43
@AllenFang AllenFang merged commit 68264b4 into react-bootstrap-table:develop Nov 10, 2018
AllenFang added a commit that referenced this pull request Nov 10, 2018
@AllenFang
Copy link
Member

https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2018/11/10/version-bump.html

Please upgrade to newest version, thanks.

YassienW pushed a commit to YassienW/react-bootstrap-table2 that referenced this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants