Use React.findDOMNode() #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Member
There was a problem hiding this comment.
👍 removed duplicated of the function call
Member
|
LGTM |
Member
Author
|
My apologies to those who needs to deal with merge conflicts after this long missive 🍒 |
Member
|
Good thing there aren't too many open PRs right now 😄 |
Member
|
Don't let that last comment keep anybody from submitting PRs we love PRs! |
Member
Author
I was taking this into account too 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to prevent copy pasting tests in future PRs
like these
#786 (comment)
pull/606/files#diff
Warning: There is the long diff ahead. 🍒
There are not only
getDOMNode=>React.findDOMNodebut also some simple DRY re-writings.
No code-logic changes.