This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Rearrange getEndValue logic #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
=========================================
+ Coverage 89.68% 89.7% +0.01%
=========================================
Files 10 10
Lines 708 709 +1
Branches 209 210 +1
=========================================
+ Hits 635 636 +1
Misses 63 63
Partials 10 10
Continue to review full report at Codecov.
|
zombieJ
reviewed
Apr 29, 2019
tests/RangeCalendar.spec.jsx
Outdated
| expect(wrapper.find('.rc-calendar-month-select').at(0).text()).toEqual('Sep'); | ||
| expect(wrapper.find('.rc-calendar-month-select').at(1).text()).toEqual('Oct'); | ||
| }); | ||
| }); |
Member
There was a problem hiding this comment.
Seems this test could be same start & end date but different time. We should mock the click operation to open time panel and check if start & end are the same date.
Contributor
Author
There was a problem hiding this comment.
@zombieJ I have rewrite test case, please check
Member
1 task
Member
|
ant-design/ant-design#16215 is not fixed because antd still stuck in rc-calendar@9.12.x |
14 tasks
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zombieJ New fix based on our discussion. Thanks for your advise.