Skip to content

Conversation

@MadCcc
Copy link
Member

@MadCcc MadCcc commented Feb 8, 2022

@vercel
Copy link

vercel bot commented Feb 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/cascader/9VyC36wushmrAQCj9YoJR3CNKjTt
✅ Preview: https://cascader-git-fix-quote-react-component.vercel.app

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #245 (8b7c87c) into master (eea408a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          15       15           
  Lines         474      474           
  Branches      124      118    -6     
=======================================
  Hits          473      473           
  Misses          1        1           
Impacted Files Coverage Δ
src/OptionList/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea408a...8b7c87c. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 8, 2022

This pull request introduces 1 alert when merging a31f0cd into eea408a - view on LGTM.com

new alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 8, 2022

This pull request introduces 1 alert when merging 6173987 into eea408a - view on LGTM.com

new alerts:

  • 1 for Incomplete string escaping or encoding

@MadCcc MadCcc merged commit 6153468 into master Feb 8, 2022
@MadCcc MadCcc deleted the fix/quote branch February 8, 2022 08:47
MadCcc added a commit that referenced this pull request Feb 8, 2022
MadCcc added a commit that referenced this pull request Feb 8, 2022
MadCcc added a commit that referenced this pull request Feb 8, 2022
* fix: label should support "

* chore: code clean

* fix: LGTM test

* chore: code clean

* fix: LGTM

* chore: code clean
MadCcc added a commit that referenced this pull request Feb 8, 2022
* fix: cascader should support double quotes in value and label (#245)

* fix: label should support "

* chore: code clean

* fix: LGTM test

* chore: code clean

* fix: LGTM

* chore: code clean

* fix: use common reg

* test: test case update

* test: test case update

* test: test case

* test: test case

* test: test case

* test: test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cascader Can no longer handle quotes (")

1 participant